More robust edge detection #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the ChatBanner component's overflow detection mechanism, improving its ability to handle edge cases where content is on the verge of overflowing.
- Implemented robust overflow checking using
getBoundingClientRect()for both width and height inweb/src/app/chat/ChatBanner.tsx - Adjusted layout with improved flex and visibility settings for better content overflow handling
- Added
useLayoutEffecthook to perform overflow checks and update state accordingly - Introduced separate visible and invisible content divs for more accurate overflow comparison
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
web/src/app/chat/ChatBanner.tsx
Outdated
| <div className="absolute top-0 left-0 invisible flex justify-center max-w-full"> | ||
| <div | ||
| ref={fullContentRef} | ||
| className={`overflow-hidden invisible${settings.enterpriseSettings.two_lines_for_chat_header ? "line-clamp-2" : "line-clamp-1"} text-center max-w-full`} |
There was a problem hiding this comment.
syntax: Missing space after 'invisible' in className
rkuo-danswer
approved these changes
Oct 9, 2024
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, ellipsis at the very edge of being necessary would not quite be caught by our edge detection
Fixes https://linear.app/danswer/issue/DAN-778/banner-width-bug
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: