add vespa + embedding timeout env variables #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds new environment variables VESPA_REQUEST_TIMEOUT and CLIENT_EMBEDDING_TIMEOUT to configure timeouts for Vespa requests and embedding clients. The changes are implemented in backend configuration files and Docker Compose files for development environments.
- Added VESPA_REQUEST_TIMEOUT in
backend/danswer/configs/app_configs.pyfor Vespa request timeouts - Introduced CLIENT_EMBEDDING_TIMEOUT in
backend/danswer/configs/model_configs.pyfor OpenAI and VoyageAI embedding timeouts - Applied VESPA_REQUEST_TIMEOUT to HTTP client instances in
backend/danswer/document_index/vespa/index.py - Implemented CLIENT_EMBEDDING_TIMEOUT in
backend/model_server/encoders.pyfor embedding clients - Added both new environment variables to
docker-compose.dev.ymlanddocker-compose.gpu-dev.yml
6 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| @@ -395,6 +395,8 @@ | |||
| os.environ.get("CUSTOM_ANSWER_VALIDITY_CONDITIONS", "[]") | |||
| ) | |||
|
|
|||
| VESPA_REQUEST_TIMEOUT = int(os.environ.get("VESPA_REQUEST_TIMEOUT", 0)) or None | |||
There was a problem hiding this comment.
style: Consider adding a comment explaining the purpose and usage of this new variable
Comment on lines
29
to
30
| # Only used for OpenAI and VoyageAI | ||
| CLIENT_EMBEDDING_TIMEOUT = int(os.environ.get("CLIENT_EMBEDDING_TIMEOUT") or 0) or None |
There was a problem hiding this comment.
style: Add a comment explaining the purpose and expected format of CLIENT_EMBEDDING_TIMEOUT
yuhongsun96
reviewed
Oct 6, 2024
yuhongsun96
reviewed
Oct 6, 2024
yuhongsun96
reviewed
Oct 6, 2024
yuhongsun96
approved these changes
Oct 6, 2024
pablonyx
force-pushed
the
customize_timeouts
branch
from
8ec7d0a to
79751f7
Compare
pablonyx
force-pushed
the
customize_timeouts
branch
from
249267c to
454437f
Compare
This was referenced Oct 19, 2024
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: