Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable removal of reranking + navigate back to search settings #2674

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Oct 3, 2024

Description

Fixes https://linear.app/danswer/issue/DAN-756/cant-remove-re-ranker

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 4:49pm

@pablonyx pablonyx changed the title k Enable removal of reranking + navigate back to search settings Oct 3, 2024
@pablonyx pablonyx marked this pull request as ready for review October 3, 2024 16:47
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the search settings management in the Danswer application, focusing on reranking removal and improved navigation.

  • Added 'Remove Reranking' button in RerankingFormPage.tsx to allow users to disable reranking
  • Introduced navigateToEmbeddingPage function in EmbeddingFormPage.tsx for smoother redirection after updates
  • Updated error and success messages in EmbeddingFormPage.tsx for better user feedback
  • Improved UI for displaying re-indexing warnings in EmbeddingFormPage.tsx
  • Added button to update search settings without re-indexing in EmbeddingFormPage.tsx

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@rkuo-danswer rkuo-danswer added this pull request to the merge queue Oct 6, 2024
Merged via the queue into main with commit 7aaf822 Oct 6, 2024
7 checks passed
@rkuo-danswer rkuo-danswer deleted the search_click branch October 6, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants