Add delete all chats option #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablonyx
force-pushed
the
delete_all_chats
branch
from
25cb3c9 to
c2c195c
Compare
|
This PR is stale because it has been open 75 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
|
This PR was closed because it has been stalled for 90 days with no activity. |
pablonyx
force-pushed
the
delete_all_chats
branch
from
c2c195c to
f71848a
Compare
pablonyx
force-pushed
the
delete_all_chats
branch
from
161872f to
ec8487b
Compare
backend/onyx/db/chat.py
Outdated
| @@ -316,6 +316,21 @@ def update_chat_session( | |||
| return chat_session | |||
|
|
|||
|
|
|||
| def delete_all_chat_sessions_for_user(user: User | None, db_session: Session) -> None: | |||
There was a problem hiding this comment.
let's make this function pure and have HARD_DELETE_CHATS be a flag set by the caller.
rkuo-danswer
approved these changes
Dec 17, 2024
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Dec 23, 2024
* Add delete all chats option * post rebase fixes * final validation * minor cleanup * move up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable client side when NEXT_PUBLIC_DELETE_ALL_CHATS_ENABLED is set
Fixes https://linear.app/danswer/issue/DAN-658/delete-all-chats-option
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: