Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes AstroCompress settings #224

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Fixes AstroCompress settings #224

merged 3 commits into from
Aug 14, 2023

Conversation

NikolaRHristov
Copy link
Contributor

@NikolaRHristov NikolaRHristov commented Aug 14, 2023

This fixes the AstroCompress settings as they were pascal cased in the later version. Also, you don't need JavaScript: true, CSS: true and SVG: true. If true the option will always default to their original value.

Fixes settings for AstroCompress as they were pascal cased in the later version.
@prototypa
Copy link
Contributor

Hi @NikolaRHristov

Thank you for this. I was not aware of the changes in settings.

In the case of the default settings, I like to leave them with true value (despite being unnecessary as it is the default behavior) so that anyone can see which settings are being optimized and which are not, in case there is a problem in the output.

@NikolaRHristov
Copy link
Contributor Author

I will re-add them.

@prototypa prototypa merged commit 7d996b1 into onwidget:main Aug 14, 2023
@NikolaRHristov NikolaRHristov deleted the main-1 branch August 14, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants