Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post thumbnail display broken on Hugo Themes demo #37

Closed
VincentTam opened this issue Aug 14, 2019 · 6 comments
Closed

Post thumbnail display broken on Hugo Themes demo #37

VincentTam opened this issue Aug 14, 2019 · 6 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@VincentTam
Copy link
Collaborator

Screenshot_2019-08-14_15-54-43

https://themes.gohugo.io/theme/hugo-swift-theme

@VincentTam VincentTam added the bug Something isn't working label Aug 14, 2019
@onweru
Copy link
Owner

onweru commented Aug 14, 2019

I have noticed this for a while now. For some reason .Params.image isn't resolved on the demo (check source).

I can't say that I have found a theme that implements images in previews well. But then I haven't been thorough in my search.

@onweru
Copy link
Owner

onweru commented Aug 15, 2019

@VincentTam, have you noticed the following about the theme's demo:

  1. There are post duplicates
  2. The demo doesn't read from the exampleSite directory of this theme. For instance, if you look closely, you won't find an article titled emoji support anywhere in the aforementioned directory 🤔

If the above observation are in fact true:

  • I cannot immediately explain (1) above
  • (2) above would explain why the image thumbnails are broken on the demo.

@onweru
Copy link
Owner

onweru commented Aug 15, 2019

@VincentTam, have you noticed the following about the theme's demo:

  1. There are post duplicates
  2. The demo doesn't read from the exampleSite directory of this theme. For instance, if you look closely, you won't find an article titled emoji support anywhere in the aforementioned directory 🤔

If the above observation are in fact true:

  • I cannot immediately explain (1) above
  • (2) above would explain why the image thumbnails are broken on the demo.

Aha, it's all explained here. Specifically in this paragraph

If your theme doesn’t fit into the Hugo Basic Example site, we encourage theme authors to supply a self-contained Hugo site in /exampleSite/, but note that for security reasons the content directory on the Hugo showcase will still be published from the Hugo Basic Example repository.

Thusly, I would not consider this issue eligible for a wont-fix

@VincentTam
Copy link
Collaborator Author

  1. There are post duplicates

@onweru Refer to item 3 in gohugoio/hugoThemes#665 (comment).

onweru pushed a commit that referenced this issue Aug 16, 2019
@onweru
Copy link
Owner

onweru commented Aug 16, 2019

  1. There are post duplicates

@onweru Refer to item 3 in gohugoio/hugoThemes#665 (comment).

It seems that this issue disappeared overnight

@VincentTam
Copy link
Collaborator Author

@onweru Thanks for update.

@onweru onweru closed this as completed Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants