Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks #2

Open
2 of 4 tasks
ahoog42 opened this issue Mar 11, 2023 · 2 comments
Open
2 of 4 tasks

Minor tweaks #2

ahoog42 opened this issue Mar 11, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ahoog42
Copy link

ahoog42 commented Mar 11, 2023

There are minor items I noticed:

  • if a line in a bash code snippet is not started with $ (so the javascript adds the $), the command export GH_TOKEN=github_path_11AAPO<snip> will have the space between the export and GH removed. If the post explicitly includes the $ in front of the command, it works as expected.
  • if a bash code snippet is multi-line and uses the \ at the end of the line, the js code will add a $ to each line but it is all part of the same command. The more I've thought about this, I wonder if there will be so many edge cases with pre-pending the $ that we might want to just remove that. Either the post add the $ explicitly or it's not present? For long commands, I like how Huge Clarity handles it with the ability to "Toggle line wrap". Thoughts?
  • would like to experiment with making the webpage take up the entire browser space as a lot of the code snippets have scrollbars now which is aesthetically annoying, imo. :-)
  • If you are able to add the Matomo support you have at a config.toml level like in Hugo Clarity, I won't have to override to add the js in layouts/_default/baseof.html (that's just a nice to have!)
@onweru
Copy link
Owner

onweru commented Mar 21, 2023

@ahoog42, yeah the toggle line wrap option could work in this case.

The rest, all good. I will fix.

@onweru onweru self-assigned this Mar 21, 2023
@onweru onweru added the enhancement New feature or request label Mar 21, 2023
@ahoog42
Copy link
Author

ahoog42 commented Apr 3, 2023

Great, ping me when you update...I don't check the repo regularly.

onweru added a commit that referenced this issue Apr 12, 2023
onweru added a commit that referenced this issue Apr 12, 2023
onweru added a commit that referenced this issue Apr 12, 2023
onweru added a commit that referenced this issue May 15, 2023
Signed-off-by: weru <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants