parse-community#8843 DEPPS7 file trigger syntax removed

onurhanife · Dec 29, 2023 · b20e268 · b20e268
1 parent 3b9f50a
commit b20e268
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 137 deletions.
diff --git a/DEPRECATIONS.md b/DEPRECATIONS.md
@@ -10,7 +10,7 @@ The following is a list of deprecations, according to the [Deprecation Policy](h
 | DEPPS4 | Remove convenience method for http request `Parse.Cloud.httpRequest` | [#7589](https://github.com/parse-community/parse-server/pull/7589)   | 5.0.0 (2022)                    | 6.0.0 (2023)                    | removed            | -     |
 | DEPPS5 | Config option `allowClientClassCreation` defaults to `false` | [#7925](https://github.com/parse-community/parse-server/pull/7925)   | 5.3.0 (2022)                    | 7.0.0 (2024)                    | deprecated            | -     |
 | DEPPS6 | Auth providers disabled by default | [#7953](https://github.com/parse-community/parse-server/pull/7953)   | 5.3.0 (2022)                    | 7.0.0 (2024)                    | deprecated            | -     |
-| DEPPS7 | Remove file trigger syntax `Parse.Cloud.beforeSaveFile((request) => {})` | [#7966](https://github.com/parse-community/parse-server/pull/7966)   | 5.3.0 (2022)                    | 7.0.0 (2024)                    | deprecated            | -     |
+| DEPPS7 | Remove file trigger syntax `Parse.Cloud.beforeSaveFile((request) => {})` | [#7966](https://github.com/parse-community/parse-server/pull/7966)   | 5.3.0 (2022)                    | 7.0.0 (2024)                    | removed            | -     |
 | DEPPS8 | Login with expired 3rd party authentication token defaults to `false` | [#7079](https://github.com/parse-community/parse-server/pull/7079)   | 5.3.0 (2022)                    | 7.0.0 (2024)                    | deprecated            | -     |
 | DEPPS9 | Rename LiveQuery `fields` option to `keys` | [#8389](https://github.com/parse-community/parse-server/issues/8389)   | 6.0.0 (2023)                    | 7.0.0 (2024)                    | deprecated            | -     |
 | DEPPS10 | Config option `encodeParseObjectInCloudFunction` defaults to `true`  | [#8634](https://github.com/parse-community/parse-server/issues/8634)   | 6.2.0 (2023)                    | 8.0.0 (2025)                    | deprecated            | -     |

diff --git a/spec/CloudCode.spec.js b/spec/CloudCode.spec.js
@@ -3918,7 +3918,7 @@ describe('saveFile hooks', () => {
     }
   });
 
-  it('legacy hooks', async () => {
+  xit('legacy hooks', async () => {
     await reconfigureServer({ filesAdapter: mockAdapter });
     const logger = require('../lib/logger').logger;
     const logSpy = spyOn(logger, 'warn').and.callFake(() => {});

diff --git a/src/Options/Definitions.js b/src/Options/Definitions.js
@@ -1063,19 +1063,19 @@ module.exports.LogLevels = {
   triggerAfter: {
     env: 'PARSE_SERVER_LOG_LEVELS_TRIGGER_AFTER',
     help:
-      'Log level used by the Cloud Code Triggers `afterSave`, `afterDelete`, `afterSaveFile`, `afterDeleteFile`, `afterFind`, `afterLogout`. Default is `info`.',
+      'Log level used by the Cloud Code Triggers `afterSave`, `afterDelete`, `afterFind`, `afterLogout`. Default is `info`.',
     default: 'info',
   },
   triggerBeforeError: {
     env: 'PARSE_SERVER_LOG_LEVELS_TRIGGER_BEFORE_ERROR',
     help:
-      'Log level used by the Cloud Code Triggers `beforeSave`, `beforeSaveFile`, `beforeDeleteFile`, `beforeFind`, `beforeLogin` on error. Default is `error `.',
+      'Log level used by the Cloud Code Triggers `beforeSave`, `beforeFind`, `beforeLogin` on error. Default is `error `.',
     default: 'error',
   },
   triggerBeforeSuccess: {
     env: 'PARSE_SERVER_LOG_LEVELS_TRIGGER_BEFORE_SUCCESS',
     help:
-      'Log level used by the Cloud Code Triggers `beforeSave`, `beforeSaveFile`, `beforeDeleteFile`, `beforeFind`, `beforeLogin` on success. Default is `info`.',
+      'Log level used by the Cloud Code Triggers `beforeSave`, `beforeFind`, `beforeLogin` on success. Default is `info`.',
     default: 'info',
   },
 };
diff --git a/src/Options/docs.js b/src/Options/docs.js
diff --git a/src/Options/index.js b/src/Options/index.js
@@ -607,15 +607,15 @@ export interface AuthAdapter {
 }
 
 export interface LogLevels {
-  /* Log level used by the Cloud Code Triggers `afterSave`, `afterDelete`, `afterSaveFile`, `afterDeleteFile`, `afterFind`, `afterLogout`. Default is `info`.
+  /* Log level used by the Cloud Code Triggers `afterSave`, `afterDelete`, `afterFind`, `afterLogout`. Default is `info`.
   :DEFAULT: info
   */
   triggerAfter: ?string;
-  /* Log level used by the Cloud Code Triggers `beforeSave`, `beforeSaveFile`, `beforeDeleteFile`, `beforeFind`, `beforeLogin` on success. Default is `info`.
+  /* Log level used by the Cloud Code Triggers `beforeSave`, `beforeFind`, `beforeLogin` on success. Default is `info`.
   :DEFAULT: info
   */
   triggerBeforeSuccess: ?string;
-  /* Log level used by the Cloud Code Triggers `beforeSave`, `beforeSaveFile`, `beforeDeleteFile`, `beforeFind`, `beforeLogin` on error. Default is `error `.
+  /* Log level used by the Cloud Code Triggers `beforeSave`, `beforeFind`, `beforeLogin` on error. Default is `error `.
   :DEFAULT: error
   */
   triggerBeforeError: ?string;

diff --git a/src/cloud-code/Parse.Cloud.js b/src/cloud-code/Parse.Cloud.js
@@ -1,6 +1,5 @@
 import { Parse } from 'parse/node';
 import * as triggers from '../triggers';
-import Deprecator from '../Deprecator/Deprecator';
 import { addRateLimit } from '../middlewares';
 const Config = require('../Config');
 
@@ -502,130 +501,6 @@ ParseCloud.afterFind = function (parseClass, handler, validationHandler) {
   );
 };
 
-/**
- * Registers a before save file function.
- *
- * **Available in Cloud Code only.**
- *
- * ```
- * Parse.Cloud.beforeSaveFile(async (request) => {
- *   // code here
- * }, (request) => {
- *   // validation code here
- * });
- *
- * Parse.Cloud.beforeSaveFile(async (request) => {
- *   // code here
- * }, { ...validationObject });
- *```
- *
- * @method beforeSaveFile
- * @deprecated
- * @name Parse.Cloud.beforeSaveFile
- * @param {Function} func The function to run before saving a file. This function can be async and should take just one parameter, {@link Parse.Cloud.FileTriggerRequest}.
- * @param {(Object|Function)} validator An optional function to help validating cloud code. This function can be an async function and should take one parameter a {@link Parse.Cloud.FileTriggerRequest}, or a {@link Parse.Cloud.ValidatorObject}.
- */
-ParseCloud.beforeSaveFile = function (handler, validationHandler) {
-  Deprecator.logRuntimeDeprecation({
-    usage: 'Parse.Cloud.beforeSaveFile',
-    solution: 'Use Parse.Cloud.beforeSave(Parse.File, (request) => {})',
-  });
-  ParseCloud.beforeSave(Parse.File, handler, validationHandler);
-};
-
-/**
- * Registers an after save file function.
- *
- * **Available in Cloud Code only.**
- *
- * ```
- * Parse.Cloud.afterSaveFile(async (request) => {
- *   // code here
- * }, (request) => {
- *   // validation code here
- * });
- *
- * Parse.Cloud.afterSaveFile(async (request) => {
- *  // code here
- * }, { ...validationObject });
- *```
- *
- * @method afterSaveFile
- * @deprecated
- * @name Parse.Cloud.afterSaveFile
- * @param {Function} func The function to run after saving a file. This function can be async and should take just one parameter, {@link Parse.Cloud.FileTriggerRequest}.
- * @param {(Object|Function)} validator An optional function to help validating cloud code. This function can be an async function and should take one parameter a {@link Parse.Cloud.FileTriggerRequest}, or a {@link Parse.Cloud.ValidatorObject}.
- */
-ParseCloud.afterSaveFile = function (handler, validationHandler) {
-  Deprecator.logRuntimeDeprecation({
-    usage: 'Parse.Cloud.afterSaveFile',
-    solution: 'Use Parse.Cloud.afterSave(Parse.File, (request) => {})',
-  });
-  ParseCloud.afterSave(Parse.File, handler, validationHandler);
-};
-
-/**
- * Registers a before delete file function.
- *
- * **Available in Cloud Code only.**
- *
- * ```
- * Parse.Cloud.beforeDeleteFile(async (request) => {
- *   // code here
- * }, (request) => {
- *   // validation code here
- * });
- *
- * Parse.Cloud.beforeDeleteFile(async (request) => {
- *   // code here
- * }, { ...validationObject });
- *```
- *
- * @method beforeDeleteFile
- * @deprecated
- * @name Parse.Cloud.beforeDeleteFile
- * @param {Function} func The function to run before deleting a file. This function can be async and should take just one parameter, {@link Parse.Cloud.FileTriggerRequest}.
- * @param {(Object|Function)} validator An optional function to help validating cloud code. This function can be an async function and should take one parameter a {@link Parse.Cloud.FileTriggerRequest}, or a {@link Parse.Cloud.ValidatorObject}.
- */
-ParseCloud.beforeDeleteFile = function (handler, validationHandler) {
-  Deprecator.logRuntimeDeprecation({
-    usage: 'Parse.Cloud.beforeDeleteFile',
-    solution: 'Use Parse.Cloud.beforeDelete(Parse.File, (request) => {})',
-  });
-  ParseCloud.beforeDelete(Parse.File, handler, validationHandler);
-};
-
-/**
- * Registers an after delete file function.
- *
- * **Available in Cloud Code only.**
- *
- * ```
- * Parse.Cloud.afterDeleteFile(async (request) => {
- *   // code here
- * }, (request) => {
- *   // validation code here
- * });
- *
- * Parse.Cloud.afterDeleteFile(async (request) => {
- *   // code here
- * }, { ...validationObject });
- *```
- *
- * @method afterDeleteFile
- * @deprecated
- * @name Parse.Cloud.afterDeleteFile
- * @param {Function} func The function to after before deleting a file. This function can be async and should take just one parameter, {@link Parse.Cloud.FileTriggerRequest}.
- * @param {(Object|Function)} validator An optional function to help validating cloud code. This function can be an async function and should take one parameter a {@link Parse.Cloud.FileTriggerRequest}, or a {@link Parse.Cloud.ValidatorObject}.
- */
-ParseCloud.afterDeleteFile = function (handler, validationHandler) {
-  Deprecator.logRuntimeDeprecation({
-    usage: 'Parse.Cloud.afterDeleteFile',
-    solution: 'Use Parse.Cloud.afterDelete(Parse.File, (request) => {})',
-  });
-  ParseCloud.afterDelete(Parse.File, handler, validationHandler);
-};
-
 /**
  * Registers a before live query server connect function.
  *
@@ -803,7 +678,7 @@ module.exports = ParseCloud;
  * @property {Integer} contentLength The value from Content-Length header
  * @property {String} ip The IP address of the client making the request.
  * @property {Object} headers The original HTTP headers for the request.
- * @property {String} triggerName The name of the trigger (`beforeSaveFile`, `afterSaveFile`)
+ * @property {String} triggerName The name of the trigger (`beforeSave`, `afterSave`)
  * @property {Object} log The current logger inside Parse Server.
  */