Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add request all languages unit test #93

Merged
merged 6 commits into from
Jul 14, 2023

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Jul 14, 2023

Context

This PR adds the final modifications and tests for the Multilingual topic (agroportal/project-management#307) done in the PRs below:

Changes

  • Fix the class portal language test for the new multilingual support (e1b9af7)
    • Now when we ask a language we ether the values with the matching language, or nil or empty if not. Before we had a fallback to show the values in the other languages to not have empty fields
  • Fix SKOS Xl tests after the new multilingual support (6825393)
    • SKOS XL labels are tagged with a language so the literal value is empty if it does not match the requested language but the object is still fetched and showed
  • Optimize request and portal lang tests by parsing the test ontology once](09a3f48)
  • Add test request all languages unit test](56b88e6)
  • Use the new getters argument to show languages](707b69d)

Now when we ask a language we ether the values with the matching language, or nil or empty if not.
Were before we had fallback to show the values in the others languages to not have empty fields
@syphax-bouazzouni syphax-bouazzouni force-pushed the support-multi-lang-part-02 branch from 2892088 to 6825393 Compare July 14, 2023 18:26
SKOS XL labels are tagged with a language so literal value is empty if it does not match the requested language  but the object is still fetched and showed
@syphax-bouazzouni syphax-bouazzouni force-pushed the support-multi-lang-part-02 branch from 6825393 to b1863f9 Compare July 14, 2023 18:58
@syphax-bouazzouni syphax-bouazzouni merged commit e1ea76d into development Jul 14, 2023
syphax-bouazzouni added a commit that referenced this pull request Sep 5, 2023
Feature: Add request all languages unit test
syphax-bouazzouni added a commit that referenced this pull request Dec 5, 2023
#96)

* fix  json serializer nil exception (#79)

if hash was missing @context key the json serializer throwed a nil exception

* Merge pull request #87 from ontoportal-lirmm/fix/achived-submission-space-optimization

Fix: Archived submission space optimization

* Merge pull request #71 from ontoportal-lirmm/feature/support-multilingual-read-one-language-from-request-parameter

Feature: Support multilingual - Add read one language from request parameter tests

* Merge pull request #73 from ontoportal-lirmm/feature/add-request-language-to-context

Feature/add request language to context

* fix  json serializer nil exception (#79)

if hash was missing @context key the json serializer throwed a nil exception

* Merge pull request #83 from ontoportal-lirmm/feature/add-request-language-to-context

Feature: add request language to context follow up

* Merge pull request #93 from ontoportal-lirmm/support-multi-lang-part-02

Feature: Add request all languages unit test

* Merge pull request #94 from ontoportal-lirmm/feature/support-multi-langual-search

Feature: Support multilangual search

---------

Co-authored-by: Raimi Solorzano Niederhausen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant