Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Search multilingual values filter #82

Merged
merged 5 commits into from
Jul 24, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add search multiple languages or all languages tests
syphax-bouazzouni committed Jun 27, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 955817af43f3f342ff7ef01d36bb18eae4cd521b
28 changes: 25 additions & 3 deletions test/controllers/test_search_controller.rb
Original file line number Diff line number Diff line change
@@ -153,7 +153,7 @@ def test_search_other_filters
.join(' ')
.include?("Funding Resource")
end
assert_equal "Funding Resource", results["collection"][0]["prefLabel"].first
assert_equal "Funding Resource", results["collection"][0]["prefLabel"]
assert_equal "T028", results["collection"][0]["semanticType"][0]
assert_equal "X123456", results["collection"][0]["cui"][0]

@@ -208,7 +208,7 @@ def test_search_provisional_class
assert_includes [10, 6], results["collection"].length # depending if owlapi import SKOS concepts
provisional = results["collection"].select {|res| assert_equal ontology_type, res["ontologyType"]; res["provisional"]}
assert_equal 1, provisional.length
assert_equal @@test_pc_root.label, provisional[0]["prefLabel"].first
assert_equal @@test_pc_root.label, provisional[0]["prefLabel"]

# subtree root with provisional class test
get "search?ontology=#{acronym}&subtree_root_id=#{CGI::escape(@@cls_uri.to_s)}&also_search_provisional=true"
@@ -217,7 +217,7 @@ def test_search_provisional_class

provisional = results["collection"].select {|res| res["provisional"]}
assert_equal 1, provisional.length
assert_equal @@test_pc_child.label, provisional[0]["prefLabel"].first
assert_equal @@test_pc_child.label, provisional[0]["prefLabel"]
end

def test_multilingual_search
@@ -251,6 +251,28 @@ def test_multilingual_search
assert_equal "ActivityEnglish", doc["prefLabel"]


get "/search?q=ActivityEnglish&ontologies=BROSEARCHTEST-0&lang=fr,es"
res = MultiJson.load(last_response.body)
assert_equal 0, res["totalCount"]

get "/search?q=ActivityEnglish&ontologies=BROSEARCHTEST-0&lang=en,es"
res = MultiJson.load(last_response.body)
refute_equal 0, res["totalCount"]
doc = res["collection"].select{|doc| doc["@id"].eql?('http://bioontology.org/ontologies/Activity.owl#Activity')}.first
refute_nil doc
expected_pref_label = {"none"=>["Activity"], "en"=>["ActivityEnglish"]}
assert_equal expected_pref_label, doc["prefLabel"]

get "/search?q=ActivityEnglish&ontologies=BROSEARCHTEST-0&lang=all"
res = MultiJson.load(last_response.body)
refute_equal 0, res["totalCount"]
doc = res["collection"].select{|doc| doc["@id"].eql?('http://bioontology.org/ontologies/Activity.owl#Activity')}.first
refute_nil doc
expected_pref_label = {"none"=>["Activity"], "en"=>["ActivityEnglish"], "fr"=>["Activité"]}
assert_equal expected_pref_label, doc["prefLabel"]



get "/search?q=ActivityEnglish&ontologies=BROSEARCHTEST-0&lang=fr&require_exact_match=true"
res = MultiJson.load(last_response.body)
assert_nil res["collection"].select{|doc| doc["@id"].eql?('http://bioontology.org/ontologies/Activity.owl#Activity')}.first