Feature: Make map_attribute support showing all languages - Support multi language search #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphax-bouazzouni
added a commit
that referenced
this pull request
Jul 20, 2023
…ngual-search Feature: Make map_attribute support showing all languages - Support multi language search
syphax-bouazzouni
added a commit
that referenced
this pull request
Jul 20, 2023
…ngual-search Feature: Make map_attribute support showing all languages - Support multi language search
syphax-bouazzouni
added a commit
that referenced
this pull request
Sep 5, 2023
…ngual-search Feature: Make map_attribute support showing all languages - Support multi language search
syphax-bouazzouni
added a commit
that referenced
this pull request
Sep 5, 2023
…ngual-search Feature: Make map_attribute support showing all languages - Support multi language search
syphax-bouazzouni
added a commit
that referenced
this pull request
Sep 5, 2023
…ngual-search Feature: Make map_attribute support showing all languages - Support multi language search
syphax-bouazzouni
added a commit
that referenced
this pull request
Sep 7, 2023
…ngual-search Feature: Make map_attribute support showing all languages - Support multi language search
syphax-bouazzouni
added a commit
that referenced
this pull request
Dec 4, 2023
* Merge pull request #24 from ontoportal-lirmm/feature/support-multilingual-read-one-language-from-request-parameter Feature : Support multilingual - Phase 1 - Read one language * Merge branch pull request #32 from feature/language-return-all * group unmapped properties by lang * Feature: group unmapped properties by language (#38) * group unmapped properties by lang * downcase language keys of unmapped properties --------- Co-authored-by: Syphax bouazzouni <[email protected]> * Feature: Support multi lingual - add show_language argument to the attributes getters (#39) * update define_method * update solution mapper * update get_preload_value * Merge pull request #40 from ontoportal-lirmm/support-muli-lang-part-02 Fix: save_model_values if unmmaped condition * Merge pull request #41 from ontoportal-lirmm/support-muli-lang-part-02 Feature: Refactor and fix the Language filter method * Merge pull request #42 from ontoportal-lirmm/feature/support-multi-langual-search Feature: Make map_attribute support showing all languages - Support multi language search --------- Co-authored-by: HADDAD Zineddine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Follow up of #41
This PR makes 'map_attributes` method handle the option showing all the languages; this method is used to map the unmapped values to the mapped ones (e.g skos:prefLabel to the model attribute prefLabel) and is used in the indexation process.
So making the method multilingual is mandatory and the first step to make the search/index multilingual.
Changes
map_attributesmethod handle the option showing all the languages (a81f12c)