Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Migrate to Ruby 3.2 #930

Open
wants to merge 10 commits into
base: development
Choose a base branch
from

Conversation

syphax-bouazzouni
Copy link
Collaborator

Changes

  • use ruby 3.2 docker file (5f9bf07)
  • Use explicit methods keys word extrapolation (3cebf52)
  • Replace exists? with exist? (b2f760f)

@syphax-bouazzouni syphax-bouazzouni changed the base branch from master to development January 31, 2025 18:10
@syphax-bouazzouni syphax-bouazzouni self-assigned this Jan 31, 2025
@syphax-bouazzouni syphax-bouazzouni added the enhancement New feature or request label Jan 31, 2025
@@ -0,0 +1,2 @@
[tools]
ruby = "2.7.8"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you add this file exactly, and why ruby 2.7.8 here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mise is a tool to have multiple ruby version in the same machine, that file specifies, the ruby version to use, in this project for now.

@Bilelkihal
Copy link
Collaborator

@syphax-bouazzouni what did you do to make sure that all the code is compatible with ruby 3.2.0 ?

@syphax-bouazzouni
Copy link
Collaborator Author

syphax-bouazzouni commented Feb 4, 2025

@syphax-bouazzouni what did you do to make sure that all the code is compatible with ruby 3.2.0 ?

Just be sure all the tests are passing and that the UI main features (browse, annotator, search, concepts page, ...) work. An fixing things that didn't work.
Also updated the docker file

@Bilelkihal
Copy link
Collaborator

@syphax-bouazzouni what did you do to make sure that all the code is compatible with ruby 3.2.0 ?

Just be sure all the tests are passing and that the UI main features (browse, annotator, search, concepts page, ...) work. An fixing things that didn't work.

Is it a good idea to include this PR in the release of this week?

@syphax-bouazzouni
Copy link
Collaborator Author

@syphax-bouazzouni what did you do to make sure that all the code is compatible with ruby 3.2.0 ?

Just be sure all the tests are passing and that the UI main features (browse, annotator, search, concepts page, ...) work. An fixing things that didn't work.

Is it a good idea to include this PR in the release of this week?

No,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants