-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Migrate to Ruby 3.2 #930
base: development
Are you sure you want to change the base?
Conversation
7349b8c
to
6638a21
Compare
@@ -0,0 +1,2 @@ | |||
[tools] | |||
ruby = "2.7.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you add this file exactly, and why ruby 2.7.8 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mise is a tool to have multiple ruby version in the same machine, that file specifies, the ruby version to use, in this project for now.
@syphax-bouazzouni what did you do to make sure that all the code is compatible with ruby 3.2.0 ? |
Just be sure all the tests are passing and that the UI main features (browse, annotator, search, concepts page, ...) work. An fixing things that didn't work. |
Is it a good idea to include this PR in the release of this week? |
No, |
Changes