Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Browse page links multi slashes #873

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Fix: Browse page links multi slashes #873

merged 3 commits into from
Nov 26, 2024

Conversation

Bilelkihal
Copy link
Collaborator

@Bilelkihal Bilelkihal commented Nov 26, 2024 •
edited
Loading

Changes

  • The bug was introduced by a function that converts API links into UI links. This function added /each time it does. So we got double slashes in the link (2c1d38b)
  • Ensure trailing slash in federation portals ui and api links (07f3c15)

@Bilelkihal Bilelkihal self-assigned this Nov 26, 2024
Bilelkihal
Bilelkihal commented Nov 26, 2024
View reviewed changes
Copy link
Collaborator Author

@Bilelkihal Bilelkihal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

syphax-bouazzouni
syphax-bouazzouni requested changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enforce the wanted behavior in code not in config. e.g check if last slash existent ,if not add it in code.

@syphax-bouazzouni syphax-bouazzouni merged commit e9bf264 into development Nov 26, 2024
3 of 4 checks passed
@Bilelkihal Bilelkihal mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syphax-bouazzouni syphax-bouazzouni syphax-bouazzouni approved these changes

Assignees

@Bilelkihal Bilelkihal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bilelkihal @syphax-bouazzouni