Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: notes and zombie mappings class label fetching and optimize concept mapping table API calls #842

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

syphax-bouazzouni
Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni commented Nov 9, 2024

Changes

  • Fix label ajax for no more existent ontologies (26a9cef) resolve note table classes columns are not shown as clickable buttons with there prefLabel #812
    image

  • Use label fetched for classes in the notes table (e48f571) resolve issue in mapping table after the new label ajax PR #841
    image

  • Optimize concept mapping tables unnecessarily calls, bellow an example with http://stageportal.lirmm.fr/ontologies/AGROVOC?p=classes&conceptid=http%3A%2F%2Faims.fao.org%2Faos%2Fagrovoc%2Fc_330988

    • before the optimization, we do these calls (11 calls to the API and effectively 9 with the cache, total 2.32 seconds)
     Getting: https://data.stageportal.lirmm.fr with {} (t: 0.0012703799984592479s - cache: hit)
     Getting: https://data.stageportal.lirmm.fr/ontologies/AGROVOC with {:include_views=>true} (t: 0.0006418720004148781s - cache: hit)
     Getting: https://data.stageportal.lirmm.fr/ontologies/AGROVOC/classes/http%3A%2F%2Faims.fao.org%2Faos%2Fagrovoc%2Fc_330988 with {:include=>"prefLabel,definition,synonym,obsolete,properties,hasChildren,childre,inScheme,memberOf"} (t: 0.0007672800020372961s - cache: hit)
     Getting: https://data.stageportal.lirmm.fr/ontologies/AGROVOC/classes/http%3A%2F%2Faims.fao.org%2Faos%2Fagrovoc%2Fc_330988/mappings with {} (t: 0.4108854149999388s - cache: miss)
     Getting: https://data.stageportal.lirmm.fr/ontologies/SENSORML with {:include=>"all"} (t: 0.26633531900006346s - cache: miss)
     Getting: https://data.stageportal.lirmm.fr/ontologies/MO with {:include=>"all"} (t: 0.2356523410016962s - cache: miss)
     Getting: https://data.stageportal.lirmm.fr/ontologies/PIZZA with {:include=>"all"} (t: 0.28804494599899044s - cache: miss)
     Getting: https://data.stageportal.lirmm.fr/ontologies/MO with {:include=>"all"} (t: 0.25294806999954744s - cache: miss)
     Getting: https://data.stageportal.lirmm.fr/ontologies/PPDO with {:include=>"all"} (t: 0.2895565639992128s - cache: miss)
     Getting: https://data.stageportal.lirmm.fr/ontologies/CGO with {:include=>"all"} (t: 0.2845640949999506s - cache: miss)
     Getting: https://data.stageportal.lirmm.fr/ontologies/SWEET with {:include=>"all"} (t: 0.2920889540000644s - cache: miss)
    
    • after (6 calls to the API, and effectively only 1 with the cache, total 0.43 seconds)
      Getting: https://data.stageportal.lirmm.fr with {} (t: 0.0020149150004726835s - cache: hit)
      Getting: https://data.stageportal.lirmm.fr/slices with {:display_links=>false, :display_context=>false} (t: 0.0013018310019106138s - cache: hit)
      Getting: https://data.stageportal.lirmm.fr with {} (t: 0.0015694670000812039s - cache: hit)
      Getting: https://data.stageportal.lirmm.fr/ontologies/AGROVOC with {:include_views=>true} (t: 0.0010685979978006799s - cache: hit)
      Getting: https://data.stageportal.lirmm.fr/ontologies/AGROVOC/classes/http%3A%2F%2Faims.fao.org%2Faos%2Fagrovoc%2Fc_330988 with {:include=>"prefLabel,definition,synonym,obsolete,properties,hasChildren,childre,inScheme,memberOf"} (t: 0.0012244399986229837s - cache: hit)
      Getting: https://data.stageportal.lirmm.fr/ontologies/AGROVOC/classes/http%3A%2F%2Faims.fao.org%2Faos%2Fagrovoc%2Fc_330988/mappings with {} (t: 0.42577466199873015s - cache: miss)
    
  • fix home page bubbles if no analytics enabled (a11dde0)

@syphax-bouazzouni syphax-bouazzouni self-assigned this Nov 9, 2024
@syphax-bouazzouni syphax-bouazzouni added bug Something isn't working enhancement New feature or request labels Nov 9, 2024
@syphax-bouazzouni syphax-bouazzouni force-pushed the fix/label-ajax-feature-followup branch 2 times, most recently from f2dc5c8 to 8d44381 Compare November 9, 2024 02:17
@syphax-bouazzouni syphax-bouazzouni force-pushed the fix/label-ajax-feature-followup branch from 8d44381 to 9435230 Compare November 9, 2024 02:33
@syphax-bouazzouni syphax-bouazzouni changed the title Fix: notes and zombie mappings class label fetching and optimize concept mapping table APO calls Fix: notes and zombie mappings class label fetching and optimize concept mapping table API calls Nov 9, 2024
Copy link
Collaborator

@Bilelkihal Bilelkihal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👏

@Bilelkihal
Copy link
Collaborator

@syphax-bouazzouni
Here we have a weird behavior, because we are saying that the mapping is internal and in the same time we show the external link icon
image

@Bilelkihal Bilelkihal merged commit dc2bb13 into development Nov 14, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants