Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Migrate Label Ajax stimulus and Jquery code to Turbo #821

Merged
merged 16 commits into from
Nov 7, 2024

Conversation

syphax-bouazzouni
Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni commented Oct 31, 2024

Fix

and contribute in #426

Changes

Screencast.from.2024-11-01.19-57-27.webm
  • Create a label fetch component that for an id/URI fetches its label if found harmonizing the code for concepts, schemes, collections, and LabelXl (bcf103c)
    image

  • Replace the label-ajax stimulus with turbo frame using ajax_link_chip (0b8fa1a)

  • Remove label-ajax stimulus code (100170f)

  • Remove bp_ajax_controller old js code and update mappings to use the label fetcher component (29930bc)

  • Remove label_link component (9a58568)

  • Fix a bug in the external mapping popup (c2fda98)
    image

@syphax-bouazzouni syphax-bouazzouni added bug Something isn't working enhancement New feature or request labels Nov 1, 2024
@Bilelkihal
Copy link
Collaborator

This is the right place for this comment

@syphax-bouazzouni
Here AGROVOC wasn't it supposed to open inside AgroPortal?
image

@Bilelkihal
Copy link
Collaborator

Bilelkihal commented Nov 4, 2024

@syphax-bouazzouni
But this screenshot was taken from AGROVOC, so it can't be not responding

@Bilelkihal
Copy link
Collaborator

@syphax-bouazzouni ping

@syphax-bouazzouni
Copy link
Collaborator Author

It does work for me, do you have the latest version, and are you using stageportal or agroportal ?
image

@syphax-bouazzouni
Copy link
Collaborator Author

syphax-bouazzouni commented Nov 7, 2024

It does work for me, do you have the latest version, and are you using stageportal or agroportal ? image

@Bilelkihal fixed in 2afeb07, it is when you select another language than English.
image

@Bilelkihal Bilelkihal merged commit a3b1d97 into development Nov 7, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants