Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: update concept mappings table UI #798

Merged
merged 17 commits into from
Oct 31, 2024

Conversation

Bilelkihal
Copy link
Collaborator

@Bilelkihal Bilelkihal commented Oct 30, 2024

Related issue: lifewatch-eric#82

Changes

  • Change mappings table font size and different spacings
  • Use a basic text instead of a chip to display concepts
  • Use icons for mappings source, home icon for internal, external-link icon for external, "I-P" for Inter-portal with a tooltip displaying the source on hover
  • Display the first and the last letter of the type and display the full type in tooltip on hover.
  • Hide relations column when it's completely empty.
  • Hide actions column if no mapping is of type REST (empty column because we display actions only for the mappings of type REST)

Screenshot
image
image

@Bilelkihal Bilelkihal self-assigned this Oct 30, 2024
@Bilelkihal
Copy link
Collaborator Author

@syphax-bouazzouni The idea of turning rows into lines instead of multiple columns didn't go well since we need to specify somehow where is the 'mappings to' where is the 'ontology' ...

@Bilelkihal Bilelkihal requested a review from jonquet October 30, 2024 16:27
@Bilelkihal
Copy link
Collaborator Author

Bilelkihal commented Oct 30, 2024

@jonquet @syphax-bouazzouni do you have in mind a concept that has some mappings of type REST, so I can use it to test actions and I replace them by icons instead of words?

app/views/mappings/_show_line.html.haml Outdated Show resolved Hide resolved
app/views/mappings/_show_line.html.haml Outdated Show resolved Hide resolved
@jonquet
Copy link

jonquet commented Oct 30, 2024

@jonquet @syphax-bouazzouni do you have in mind a concept that has some mappings of type REST, so I can use it to test actions and I replace them by icons instead of words?

You can create one ;)

@syphax-bouazzouni
Copy link
Collaborator

syphax-bouazzouni commented Oct 30, 2024

@Bilelkihal here is my proposed version, the idea is mostly to remove the source and relations columns.

Not logged-in version

image

If logged in use icons for the actions

image

For the type badges added a tooltip to explain each

image

@syphax-bouazzouni
Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni changed the title Fix: mappings table style Fix: concept mappings table UI Oct 31, 2024
@Bilelkihal
Copy link
Collaborator Author

@syphax-bouazzouni I updated the screenshots in the PR description

@syphax-bouazzouni syphax-bouazzouni changed the title Fix: concept mappings table UI Feature: update concept mappings table UI Oct 31, 2024
@syphax-bouazzouni syphax-bouazzouni merged commit f1773c1 into development Oct 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants