Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Disable slices not hiding the slices section in the home page #797

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Fix: Disable slices not hiding the slices section in the home page #797

merged 4 commits into from
Oct 30, 2024

Conversation

syphax-bouazzouni
Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni commented Oct 30, 2024 •
edited
Loading

When we disable the slices using $ENABLE_SLICES=false in the config files we still see in the home page the slices section. This PR prevents that.

@syphax-bouazzouni syphax-bouazzouni self-assigned this Oct 30, 2024
@syphax-bouazzouni syphax-bouazzouni added the bug Something isn't working label Oct 30, 2024
@Bilelkihal Bilelkihal self-requested a review October 30, 2024 16:38
@Bilelkihal Bilelkihal merged commit e616842 into development Oct 30, 2024
8 checks passed
@Bilelkihal Bilelkihal mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bilelkihal Bilelkihal Bilelkihal approved these changes

Assignees

@syphax-bouazzouni syphax-bouazzouni

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syphax-bouazzouni @Bilelkihal