Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Include views in ontologies selector of search page #784

Merged

Conversation

Bilelkihal
Copy link
Collaborator

@Bilelkihal Bilelkihal commented Oct 24, 2024

Related issue: #709
image

@Bilelkihal
Copy link
Collaborator Author

@jonquet
I made it so that views are always included in the ontology selector, regardless of whether the user selects the "only views" option or not.
Adding a JS logic to include them only when the user clicks on the option only views would add complexity without much benefit.
What do you think?

@Bilelkihal Bilelkihal self-assigned this Oct 24, 2024
Copy link
Collaborator Author

@Bilelkihal Bilelkihal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syphax-bouazzouni syphax-bouazzouni changed the title Fix: Include views in ontologies selector Fix: Include views in ontologies selector of search page Oct 26, 2024
@syphax-bouazzouni syphax-bouazzouni merged commit fea0612 into development Oct 26, 2024
2 of 4 checks passed
@jonquet
Copy link

jonquet commented Oct 26, 2024

That's sound like ok for me to include always Views in this selector.
This is good to avoid overkill ourselves with too complex logics.

Do you think it would be possible to actually add a small symbol or word "[view]" at the end of a line in the selector when this is a view?

@jonquet
Copy link

jonquet commented Oct 29, 2024

Latest discussion mention to include the [view] badge (or at least the sentence "[view]") at the end of the line of a view in the menu.

@syphax-bouazzouni
Copy link
Collaborator

Latest discussion mention to include the [view] badge (or at least the sentence "[view]") at the end of the line of a view in the menu.

@jonquet open another issue for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants