Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: federated browse page not updating the categories when portals changed #779

Merged
merged 9 commits into from
Oct 23, 2024

Conversation

Bilelkihal
Copy link
Collaborator

@Bilelkihal Bilelkihal commented Oct 21, 2024

Changes

  • Sort by name when federation is enabled in Browse page (8b1e5b5)
  • Refactor and clean the browse into helpers (b6b9a44), (e2d9924), (5685168), and (f7b131c)
  • Fix the bug of mixing the section filters because this.element was the container not the filters section blocks (de13f56)
  • Update the categories section in browse page if request_portal changed (bfe4c28)
Screencast.from.2024-10-22.07-37-51.mp4

@syphax-bouazzouni syphax-bouazzouni changed the title Feature: Improve federate browse page Fix: federated browse page not updating the categories when portals changed Oct 22, 2024
@syphax-bouazzouni syphax-bouazzouni force-pushed the feature/improve-federate-browse branch from bfe4c28 to 6480558 Compare October 22, 2024 05:38
Copy link
Collaborator Author

@Bilelkihal Bilelkihal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve those changes my side ✅

@syphax-bouazzouni syphax-bouazzouni merged commit e8df167 into development Oct 23, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants