Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: slices homepage metrics count #775

Merged
merged 11 commits into from
Oct 24, 2024
Merged

Conversation

syphax-bouazzouni
Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni commented Oct 11, 2024

fix #762

Example of crop slice
image

Compared to the not sliced metrics
image

@Bilelkihal
Copy link
Collaborator

Bilelkihal commented Oct 15, 2024

@syphax-bouazzouni It's not working (even for the ontologies number).
To test it locally, enable slices in the config file and enter to the slice using a link like inrae.localhost:3000.
(It's better to use AgroPortal api)

@Bilelkihal
Copy link
Collaborator

Bilelkihal commented Oct 23, 2024

@syphax-bouazzouni
image

  • The metrics that are correct are: ontologies, classes, individuals and properties
  • The metrics that still doesn't change whether we choose a slice or no are: projects and mappings

Copy link
Collaborator Author

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the remaining metrics to filter.

@Bilelkihal
Copy link
Collaborator

@syphax-bouazzouni, good job. I confirm that it's working correctly.

@Bilelkihal Bilelkihal merged commit 18a4cac into development Oct 24, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants