Fix : Add language-specific anchors to footer section links and the cookie banner #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammedBkf
changed the title
syphax-bouazzouni
requested changes
Sep 29, 2024
app/views/layouts/_footer.html.haml
Outdated
| - section_links.each do |section , link| | ||
| %a{:href => link, :target => "_blank"} | ||
| - anchor_key = "layout.footer.#{section}_anchor" |
There was a problem hiding this comment.
it can be cleaner doing just this: - anchor = I18n.t("layout.footer.#{section}_anchor", default: ""), but it needs to be tested.
There was a problem hiding this comment.
Indeed, it's cleaner that way. I tested it, works just fine
|
Update also the sample config file to be as you pointed in your "NB" |
muhammedBkf
force-pushed
the
fix/footer_links_language-specific_anchors
branch
from
4a7bae6 to
ba03b3c
Compare
This was referenced Sep 29, 2024
Closed
|
Does not seems to work on StagePortal. |
@Bilelkihal you will need to update the config file as described in the description (and remember to do it in production also) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #755.
Adding language-specific anchors to footer section links and the cookie banner so that it points to the correct language section in the docs.
NB:
bioportal_web_ui/config/bioportal_config_env.rb.sample
Lines 288 to 292 in 4cdc1aa