Fix: enhance agents errors messages #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilelkihal
force-pushed
the
feature/enhance-agents-erors-messages
branch
from
a89c407 to
de9192d
Compare
syphax-bouazzouni
requested changes
Aug 1, 2024
|
Attention le comportement osit unifié avec https://github.com/ontoportal-lirmm/bioportal_web_ui/blob/master/app/controllers/users_controller.rb#L261 Philosophie générale: on pre-traite un peu la données a envoyer au back ... mais les vrais validateurs sont dans le back (ou pas dans ce cas la)/. |
Bilelkihal
commented
Aug 5, 2024
Bilelkihal
force-pushed
the
feature/enhance-agents-erors-messages
branch
from
84de17f to
29e12bb
Compare
syphax-bouazzouni
approved these changes
Aug 6, 2024
syphax-bouazzouni
pushed a commit
that referenced
this pull request
Aug 8, 2024
* accept different orcid forms in agents creation/update form * humanize empty values errors in creating and updating agents * accept ror identifier in all forms and handle it in the UI * humanize identifier already used when updating agent * put agent form errors in local lang files * extract generate agents errors function * remove ror/orcid ui validators * enhance invalid agents identifiers url error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue:
agroportal/project-management#577
related back PR:
ontoportal-lirmm/ontologies_linked_data#152
Changes:
Humanization of the agents form errors (errors handled: nil/empty required values errors, unique identifiers errors).
Accept all forms of ORCIDs (16 digits, ORCID URL with or without "www." and with or without scheme http/https) then in all cases we pass it in this form to the back: 1234-1234-1234-1234
Accept all forms of RORs (9 characters, Full URL with 'https://ror.org/' with or without scheme http/https) then in all cases we pass it in this form to the back: 02mn0vt57
If the orcid is not valid, we pass the value invalid_orcid and the back generates an error
if the ror is not valid, we pass the value invalid_ror and the back generates an error
Demos:
Enregistrement.de.l.ecran.2024-08-01.a.16.32.16.mov
Enregistrement.de.l.ecran.2024-08-01.a.16.28.00.mov