Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: concept details table layout max-with when long strings #649

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Fix: concept details table layout max-with when long strings #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e0fc0fc
fix concepts table layout when we put very long strings
Bilelkihal Jun 4, 2024
bd0399e
fix concepts json button position
Bilelkihal Jun 4, 2024
273f805
use a css class intead of an id for the concepts_json_button
Bilelkihal Jun 4, 2024
e7d58bc
move concepts_json_button css class from concept details file to conc…
Bilelkihal Jun 6, 2024
c77c20b
remvoe #concepts_json_link unsued style
syphax-bouazzouni Jun 6, 2024
ea2eab3
Merge branch 'development' into fix/concept-details-table-layout-long…
syphax-bouazzouni Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/assets/stylesheets/components/concept_details.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,8 @@

.concept_details_component table th {
width: 220px;
}

.concept_details_component td, .concept_details_component th{
max-width: 200px;
}
4 changes: 2 additions & 2 deletions app/assets/stylesheets/concepts.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ div.synonym-change-request button {
display: inline !important;
}

#concepts_json_link{
margin-top: -4px;
.concepts_json_button{
margin-right: 5px;
margin-top: -4px;
}
3 changes: 2 additions & 1 deletion app/views/concepts/_show.html.haml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
= link_to("#classPermalinkModal", class: "class-permalink nav-link", title: t('concepts.permanent_link_class'), aria: {label: t('concepts.permanent_link_class')}, data: {toggle: "modal", current_purl: "#{@current_purl}"}) do
%i{class: "fas fa-link", aria: {hidden: "true"}}
%div{'data-concepts-json-target': 'button'}
= render RoundedButtonComponent.new(link: "#{@ontology.id}/classes/#{escape(@concept.id)}?display=all&apikey=#{get_apikey}", target:'_blank')
.concepts_json_button
= render RoundedButtonComponent.new(link: "#{@ontology.id}/classes/#{escape(@concept.id)}?display=all&apikey=#{get_apikey}", target:'_blank')
- apikey = "apikey=#{get_apikey}"
- baseClassUrl = "#{@ontology.id}/classes/#{escape(@concept.id)}"
- c.item(title: t('concepts.details'), path: '#details', selected: true, json_link: "#{baseClassUrl}?#{apikey}&display=all")
Expand Down
Loading