Feature: Add agent tooltip in summary page #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphax-bouazzouni
requested changes
Dec 7, 2023
syphax-bouazzouni
requested changes
Dec 7, 2023
syphax-bouazzouni
requested changes
Dec 7, 2023
syphax-bouazzouni
requested changes
Dec 14, 2023
|
@syphax-bouazzouni |
syphax-bouazzouni
added a commit
that referenced
this pull request
Dec 19, 2023
* Add agent tooltip in the summary page * extract generate agent tooltip HTML to a function * put back display_agent method, and extract agent_chip_componentt * change generate_agent_tooltip function name * make display_agent uses agent_chip_component * add icon to agent chip component * fix agent chip style * fix when the agent is a string issue * Make agent chip text truncate * fix affliatinons issue in agent tooltip * Treat the case when the agent have no affiliation in the agent tooltip * remove scroll indicators from chips in summary page * fix agent system tests --------- Co-authored-by: Syphax Bouazzouni <[email protected]>
syphax-bouazzouni
added a commit
that referenced
this pull request
Dec 19, 2023
* Fix: Remove JQuery validate (#410) * remove the jquery validation of group and category * add the validation of category fields * add the validation of group fields * remove jquery validate imports * Feature: Add agent display component (#404) * Add agent tooltip in the summary page * extract generate agent tooltip HTML to a function * put back display_agent method, and extract agent_chip_componentt * change generate_agent_tooltip function name * make display_agent uses agent_chip_component * add icon to agent chip component * fix agent chip style * fix when the agent is a string issue * Make agent chip text truncate * fix affliatinons issue in agent tooltip * Treat the case when the agent have no affiliation in the agent tooltip * remove scroll indicators from chips in summary page * fix agent system tests --------- Co-authored-by: Syphax Bouazzouni <[email protected]> * Fix: Optimize some pages load speed (metadata curator, summary, agents admin) (#411) * update the summary watch button to be lazy loaded * fix submission edit page error state * limit the fair score http call to the service timeout to be fast-failing * optimize the submissions partial to not load latest submission twice * optimize the submission update page speed * optimize the metadata curator call to use the new submissions endpoint * update ontoportal dev script to accept local api client code * fix show_category_name helper for no valid ids * fix content language selector component breaking the tab layout on init * fix submission and agent system test after the changes in the api cient * Fix: Optimize landscape pages load speed and integration with the new model (#415) * update the landscape page to work with the backend model * optimize the landscape loading page speed by removing duplicate calls --------- Co-authored-by: SirineMhedhbi <[email protected]> Co-authored-by: Bilel Kihal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done in this PR:
I added a tooltip when we hover an agent in people and organizations bloc in summary page,
The information I'm displaying is: Type (using an icon), name, email, identifiers and affiliations of the agent.
there are two types of agents:
person:
Organization:
** Also I added an icon to indicate the type of the agent in the agent chip
Ps. there are some agents have no type (only name and email) and they are considered as persons.