Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show ontology data by one language - part 2 #225

Merged
merged 34 commits into from
Mar 27, 2023

Conversation

syphax-bouazzouni
Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni commented Mar 27, 2023

Follow up of #216

Changes

  • Add request_lang helper (92842cf)

  • Filtrer by language: get_class (4ea7592) ; concept_details and concept_children (e39f1b6); concept_label (5f1f963), tree_view (eaa6edd) , collections and schemes (da2e5a7); concept_members (ccd5770), concept_sorted_by_date (fec0e0d)

  • Disable the language_selector if no in the sections: classes, instances, collections, schemes

  • Make EN as the default request_lang (61b712e)

  • Some code refactoring (see commits)

haddadzineddine and others added 30 commits March 17, 2023 11:20
…ge change, and show elements in selected language when expanding tree.

1- show  language selector only on needed classes.

2- When we change the language selector we need to update the concept details and the tree

3- When we expand an element in the tree, we need to see the elements in the selected language
@syphax-bouazzouni
Copy link
Collaborator Author

What stays to do

  • Tell the user when we don't find a prefLabel (for now we show the URI if prefLabel equal nil)
  • Make the search (jump to) work by language
  • ....

Copy link
Collaborator Author

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@syphax-bouazzouni syphax-bouazzouni merged commit ee7d66f into development Mar 27, 2023
@syphax-bouazzouni syphax-bouazzouni changed the title Feature: Show ontology data by one language Feature: Show ontology data by one language - part 2 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants