Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small change in date listing for ontology versions on description page #30

Closed
Tracked by #150
jonquet opened this issue Jan 11, 2022 · 5 comments
Closed
Tracked by #150
Assignees
Labels
enhancement New feature or request

Comments

@jonquet
Copy link

jonquet commented Jan 11, 2022

Currently the 3 dates properties are :

"creationDate": "XXX", => Uploaded in the UI
"released": "XXX", => Released in the UI
"modificationDate": "XXX" => not in the UI
(last may be null but no the 2 other ones)

Capture d’écran 2022-01-11 à 16 41 01

The problem

We can't see the modification date which is the most important one (the date an ontology was modified (and thus a new version created)).

The need

Add a column in between Released and Uploaded called "Modified" that will display the modificationDate property

@syphax-bouazzouni
Copy link
Collaborator

Implementation

image

Deployment

Deploy on

  • Stageportal
  • Agroportal
  • Bioportal

@syphax-bouazzouni
Copy link
Collaborator

Case of empty modification date, we have the following
image

@jonquet
Copy link
Author

jonquet commented Jan 25, 2022

The features looks good to me.
As a little complement I would add something:

At the side of each date (right on the right not on a tab as in next figure) a question mark which will display on mouse over a little comment about the property. Similar to whats done in the edit submission page:

Capture d’écran 2022-01-25 à 17 56 21

The comments can actually be the same than on the edit submission page.

For "uploaded" the comment maybe "Date of uploading in [portal name]"

@syphax-bouazzouni
Copy link
Collaborator

The add-on of having a help tooltilp like the one in the submissions edit page is done and deployed in stage (see below)
image

@jonquet
Copy link
Author

jonquet commented Jan 26, 2022

Perfect. The UI is really appropriate.

@jonquet jonquet closed this as completed Jan 26, 2022
syphax-bouazzouni added a commit that referenced this issue Nov 21, 2023
* disable edit link in the  submissions table

* fix user edit action returning always password empty error
syphax-bouazzouni added a commit that referenced this issue Dec 12, 2024
…ign-to-agroportal-3.0.1

Feature: Align to AgroPortal 3.0.1 release
syphax-bouazzouni pushed a commit that referenced this issue Dec 15, 2024
Fix undefined method for nil class error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants