Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show collections tab if not roots found #298

Closed
4 tasks done
syphax-bouazzouni opened this issue Jul 22, 2023 · 0 comments · Fixed by #311
Closed
4 tasks done

Show collections tab if not roots found #298

syphax-bouazzouni opened this issue Jul 22, 2023 · 0 comments · Fixed by #311
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@syphax-bouazzouni
Copy link
Collaborator

syphax-bouazzouni commented Jul 22, 2023

Context

When a SKOS resource or Ontology didn't define roots or we couldn't retrieve them,
We show only an error message and don't give the option to the user to see if can find it by list (collection) or by date.

Image

Issue

We can't see by collections or dates, even the resource-defined concepts by collection, or is flat.

To reproduce

We have this use case https://agroportal.lirmm.fr/ontologies/SENSORML, where @jonquet has added a fake root in the file to make it work.

So to reproduce we can take that file remove the fake root and re-parse the resource.

Another option is in the code to change this line https://github.com/ontoportal-lirmm/bioportal_web_ui/blob/master/app/controllers/application_controller.rb#L455 to put roots = [] to simulate a resource with no roots

Requirements

  • not show error message in big
  • Select the list tab if there are collections
  • Select the dates tabs if there are no empty
  • Else select all the classes with auto-loading when scrolling down
@syphax-bouazzouni syphax-bouazzouni added bug Something isn't working enhancement New feature or request labels Jul 22, 2023
@syphax-bouazzouni syphax-bouazzouni changed the title Show collections if not roots found Show collections tab if not roots found Jul 22, 2023
syphax-bouazzouni pushed a commit that referenced this issue Apr 17, 2024
The sanitize method was stripping the href attribute. See #298.
syphax-bouazzouni pushed a commit that referenced this issue Apr 17, 2024
…onward (#17)

* Bump bootstrap from 4.1.0 to 5.2.3

* Refactor home page cards

* Refactor top navigation bar

* Fix close buttons on dismissible alerts

* Refactor sticky footer code

* Repair Admin tabbed interface

* Refactor form to fix spacing issues

* Remove unused styles

* Remove unnecessary nested fluid container

* Refactor form to fix spacing issues

* Fix alignment issue with annotator plus spinner

* Fix broken tabbed navigation for ontology tabs

* Remove text decoration in the ontology info bar

* Clean up display of ontology information buttons

* Restore bold font in ontology metadata cards

* Restore bold font for submissions header

* Remove anchor text decoration for metadata cards

* Restore border at the top of the submissions table

* Remove bottom border from show more subs cell

* Restore top borders to details and metrics tables

* Fix add proposal dropdown button

* Fix class permalink dialog

* Fix create new mapping dialog

* Fix add and remove synonym dialogs

* Adjust buttons on create mapping dialog

* Refactor create new mapping form

* Add back platforms overwritten during merge

* Refactor horizontal form to fix spacing issues

* Restore padding in class details pane

* Refactor class search form to fix spacing issues

* Restore appearance of search links

* Restore left alignment in ontology column

* add download link for OntoPortal Virtual Appliance v3.2.1

* Restore link appearance in ontology column

* Refactor form to fix spacing and alignment issues

* Fix footer layout and presentation issues

* Remove text-decoration for ontology visits

Also prevent wrapping of column header text

* Fix node obsoletion form

* Fix node rename form

* jQuery toggle no longer needed

* Fix create and remove synonym dialog forms

* Fix jump to input group

* Remove text decoration for details and mappings

* Replace Uglifier with Terser

Fixes Uglifier::Error that prevents asset precompilation

* Pin graphql gem to less than 2.1

* Pin base64 gem to 0.1.0

See ncbo#293

* Remove text decoration from ontology list

* Restore space underneath filter text box

* Add download link for Virtual Appliance v3.2.2

* Use regular dropdown instead of split type

* Display site notices above loading splash div

Prevents a jumpy page appearance when the ontologies loading message is displayed

* Update Gemfile.lock

* Adjust font size for autocomplete results list

Resolves #296

* Fix login requirement for notes email subscriptions

The sanitize method was stripping the href attribute. See #298.

* Encode user ID portion of subscriptions params

Resolves #300

* Fix Uncaught TypeError on notes emails subscribe

See #298

* Fix some RuboCop warnings

* Refactor subscribed_to_ontology? method

Account for the case where the user parameter doesn't have the ontology attribute loaded on the list of associated subscription objects

---------

Co-authored-by: Alex Skrenchuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
2 participants