Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of annotators in the UI code base #22

Closed
syphax-bouazzouni opened this issue Dec 22, 2021 · 5 comments
Closed

A lot of annotators in the UI code base #22

syphax-bouazzouni opened this issue Dec 22, 2021 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@syphax-bouazzouni
Copy link
Collaborator

syphax-bouazzouni commented Dec 22, 2021

We have a duplicate route for the annotator plus

  1. First one http://agroportal.lirmm.fr/annotator

  2. Second one http://agroportal.lirmm.fr/annotatorplus

The cause is that the upstream (NCBO branch) didn't merge the annotator plus, instead they did a redirection link to it

And we have a third annotator that is http://stageportal.lirmm.fr/ncbo_annotatorplus

@syphax-bouazzouni syphax-bouazzouni added the bug Something isn't working label Dec 27, 2021
@syphax-bouazzouni syphax-bouazzouni changed the title Annotator plus duplication A lot of annotators in the UI Mar 23, 2022
@syphax-bouazzouni syphax-bouazzouni added the question Further information is requested label Mar 23, 2022
@syphax-bouazzouni
Copy link
Collaborator Author

@jonquet do we plan to do anything to clarify all this?

@syphax-bouazzouni syphax-bouazzouni changed the title A lot of annotators in the UI A lot of annotators in the UI code base Mar 23, 2022
@jonquet
Copy link

jonquet commented Mar 24, 2022

To be discussed. Apparently nothing.
The annotatorplus route on our boxes is hidden as the default annotator does use the proxy.
The ncbo_annotatorplus route is specific to SIFR BioPortal and this one is functionally different and both are displayed in the UI.

@jonquet jonquet removed the bug Something isn't working label Mar 24, 2022
@syphax-bouazzouni syphax-bouazzouni added the documentation Improvements or additions to documentation label Nov 10, 2023
@syphax-bouazzouni
Copy link
Collaborator Author

syphax-bouazzouni commented Nov 10, 2023

The thing to do for this is:

  • Write technical documentation explaining the difference and where are their code (@jonquet)
  • Do a unit test for each of them, to prevent the case, that they went done without us knowing (@syphax-bouazzouni)

@syphax-bouazzouni
Copy link
Collaborator Author

@Bilelkihal can you do this, now that you are an annotator expert?

The thing to do for this is:

  • Write technical documentation explaining the difference and where are their code (@jonquet)
  • Do a unit test for each of them, to prevent the case, that they went done without us knowing (@syphax-bouazzouni)

@syphax-bouazzouni
Copy link
Collaborator Author

Did the documentation here: https://doc.jonquetlab.lirmm.fr/share/eb82cfc3-53e6-40c8-9bb4-44676b3f3b57
A system test was done for our annotator, the others have not been tested and are not a priority for now.

syphax-bouazzouni added a commit that referenced this issue Oct 10, 2024
Sync: bring OntoPortal up-to-date with BioPortal releases 6.17.0 and onward
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants