This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Fix method name clash #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphql-ruby v1.8.7 introduced a private method with the same name `apply_scope` in GraphQL::Schema::Field, which happens to be where this module was designed to be prepended to. Close ontohub#63
|
@phyrog any chance of you having time to go through this anytime soon? |
|
@schonert thanks for the ping. As I am no longer actively involved with Ontohub I did not get a notification about this. I will have a look at it tomorrow |
|
@phyrog let me know if i can be of any help |
|
Hi folks! Any news with it? I tried to use this library and came across to this issue too( I also paid attention on that tests can't be passed on the master branch. How can I help you with it? Feel free to ask for help if it's needed. I'm continuing explore the sources anyway. cc @phyrog |
Batou99
added a commit
to conferize/graphql-pundit
that referenced
this pull request
Mar 22, 2019
|
Its fixed with new version of graphql gem 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphql-ruby v1.8.7 introduced a private method with the same name
apply_scopein GraphQL::Schema::Field, which happens to be wherethis module was designed to be prepended to.
Close #63