Merge pull request #1224 from ontodev/fix-1220

Exclude deprecated from lowercase_definition check
ontodev · Nov 13, 2024 · 27d5fd3 · 27d5fd3
2 parents 088d566 + b5f9c05
commit 27d5fd3
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,11 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## Fixed
+- Add missing filter for deprecated in lowercase_definition check [#1220]
+- Bug was fixed that caused logical axioms with axiom annotations not to be processed correctly when merging axiom annotations [#1223]
+
 ## [1.9.7] - 2024-10-30
 
 ### Fixed
 - Output inferred object property assertions using Whelk reasoner, by updating to Whelk 1.1.3. [#1121]
-- Bug was fixed that caused logical axioms with axiom annotations not to be processed correctly when merging axiom annotations [#1223]
 
 ### Changed
 - Update Whelk to 1.2.1 [#1221]
@@ -413,7 +416,9 @@ First official release of ROBOT!
 [`validate`]: http://robot.obolibrary.org/validate
 [`verify`]: http://robot.obolibrary.org/verify
 
+[#1223]: https://github.com/ontodev/robot/pull/1223
 [#1221]: https://github.com/ontodev/robot/pull/1221
+[#1220]: https://github.com/ontodev/robot/issues/1220
 [#1211]: https://github.com/ontodev/robot/pull/1211
 [#1194]: https://github.com/ontodev/robot/pull/1194
 [#1193]: https://github.com/ontodev/robot/pull/1193

diff --git a/docs/report_queries/lowercase_definition.md b/docs/report_queries/lowercase_definition.md
@@ -7,14 +7,16 @@
 **Solution:** Capitalize the first letter of the definition, or disregard this INFO.
 
 ```sparql
+PREFIX owl: <http://www.w3.org/2002/07/owl#>
 PREFIX obo: <http://purl.obolibrary.org/obo/>
 
 SELECT DISTINCT ?entity ?property ?value WHERE {
   VALUES ?property { obo:IAO_0000115
                      obo:IAO_0000600 }
   ?entity ?property ?value .
-  FILTER (!regex(?value, "^[A-Z0-9]"))
+  FILTER NOT EXISTS { ?entity owl:deprecated true }
   FILTER (!isBlank(?entity))
+  FILTER (!regex(?value, "^[A-Z0-9]"))
 }
 ORDER BY ?entity
 ```
diff --git a/robot-core/src/main/resources/report_queries/lowercase_definition.rq b/robot-core/src/main/resources/report_queries/lowercase_definition.rq
@@ -6,13 +6,15 @@
 #
 # **Solution:** Capitalize the first letter of the definition, or disregard this INFO.
 
+PREFIX owl: <http://www.w3.org/2002/07/owl#>
 PREFIX obo: <http://purl.obolibrary.org/obo/>
 
 SELECT DISTINCT ?entity ?property ?value WHERE {
   VALUES ?property { obo:IAO_0000115
                      obo:IAO_0000600 }
   ?entity ?property ?value .
-  FILTER (!regex(?value, "^[A-Z0-9]"))
+  FILTER NOT EXISTS { ?entity owl:deprecated true }
   FILTER (!isBlank(?entity))
+  FILTER (!regex(?value, "^[A-Z0-9]"))
 }
 ORDER BY ?entity