Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEP15: Wallet Standard #56

Closed
wants to merge 9 commits into from
Closed

OEP15: Wallet Standard #56

wants to merge 9 commits into from

Conversation

WyattMufson
Copy link
Contributor

This OEP introduces a standard to unify the implementation of the wallet file specification across the various SDKs and applications.

This will resolve #49

OEPS/OEP-9.mediawiki Outdated Show resolved Hide resolved
@WyattMufson
Copy link
Contributor Author

@kunxian-xia @AlverLyu @mooorex @Honglei-Cong this should be ready to go

@WyattMufson WyattMufson changed the title Wallet Standard OEP15: Wallet Standard Jul 16, 2019
@WyattMufson
Copy link
Contributor Author

@javajoker this one too - any other comments?

@AlverLyu
Copy link

Thanks for your proposal.
We are working to draft a new standard version since current implementation is not that proper.

@mooorex
Copy link

mooorex commented Jul 17, 2019

Yes, it is a de facto implementation, but some items will make people confuse in this specification, such as the Control object includes an unexpected item "address". Besides, we have own encrypted key format rather than NEP-2 format.
it is not very flexible, such as it supports only one type of KDF. Is it necessary to support more cryptographic algorithms, especially different KDFs in this standard?
So, in a nutshell, is it more suitable to define a new version?

@WyattMufson
Copy link
Contributor Author

@AlverLyu @mooorex gotcha, makes sense. Would be happy to help contribute to the new standards.

@Honglei-Cong
Copy link
Member

As discussed, close this PR and starting a new one when new wallet standard draft available?

@WyattMufson
Copy link
Contributor Author

@Honglei-Cong We should put the conversation on the new standard here. The conversation should be open to the public - so this can act as a starting point

@WyattMufson WyattMufson closed this Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OEP: Wallet Standard
4 participants