Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow comment recommendation and remove SDH type cast as iceGatheringComplete is public #1081

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Follow comment recommendation and remove SDH type cast as iceGatheringComplete is public #1081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c52e277
chore: add .idea to .gitignore
May 29, 2024
6d9c199
refactor: remove SDH cast as the iceGatheringComplete is already public
May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ test/spec/api/*.js
test/spec/core/*.js
test/spec/platform/web/*.js
test/support/**/*.js
.idea/
6 changes: 1 addition & 5 deletions src/platform/web/session-manager/session-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,11 +574,7 @@ export class SessionManager {
onicecandidate: (event) => {
if (event.candidate?.type === "srflx") {
this.logger.log(`[${inviter.id}] Found srflx ICE candidate, stop waiting...`);
// In sip.js > 0.20.1 this cast should be removed as iceGatheringComplete will be public
const sdh = sessionDescriptionHandler as SessionDescriptionHandler & {
iceGatheringComplete: () => void;
};
sdh.iceGatheringComplete();
sessionDescriptionHandler.iceGatheringComplete();
}
}
};
Expand Down