Add HaveValue matcher #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @thediveo sorry for the delay (🦃-day and all). This looks good but I'm gonna make a couple comments on the commit. |
onsi
reviewed
Nov 29, 2021
onsi
reviewed
Nov 29, 2021
|
After finally being able to dynamically create arbitrary deep stargazing actual values using reflection, what do you prefer? Augmenting the PR with new commits or replacing the commits (if latter, how so)? |
…ns errors instead of failures
onsi
reviewed
Dec 6, 2021
|
lgtm - thanks! I have a couple of new things I want to add to Gomega this/next week - once that's done I'll cut a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HaveValuematcher (as discussed in [RFC] new Value matcher? #484) that optionally dereferences pointers and interfaces into values, even repeatedly, as needed.HaveValuematcher.