Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set consistently and eventually defaults on init #443

Merged
merged 1 commit into from
May 21, 2021
Merged

Set consistently and eventually defaults on init #443

merged 1 commit into from
May 21, 2021

Conversation

tlwr
Copy link
Contributor

@tlwr tlwr commented May 6, 2021

Closes #434

What

Adds an init hook which calls a helper for each default we want to set

Adds environment variables:

  • GOMEGA_DEFAULT_CONSISTENTLY_DURATION
  • GOMEGA_DEFAULT_CONSISTENTLY_POLLING_INTERVAL
  • GOMEGA_DEFAULT_EVENTUALLY_TIMEOUT
  • GOMEGA_DEFAULT_EVENTUALLY_POLLING_INTERVAL

Why

As a Vito, I want to set the duration/timeout/poll interval for Consistently and Eventually without stressing about my CI system being under load

Closes #434

@tlwr
Set consistently and eventually defaults on init
5e6f879 
Using environment variables

Closes onsi#434

Signed-off-by: toby lorne <[email protected]>
@onsi
Copy link
Owner

onsi commented May 21, 2021

thanks - this looks good to me

@onsi onsi merged commit 12eb778 into onsi:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow environment variables to override the default Eventually and Consistently timeouts
2 participants
@tlwr @onsi