Add syscall for riscv64 architecture #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really have any way to test this but it seems reasonable to me. We do the same thing for other architectures. Thanks for your contribution! |
|
Thanks @williammartin , Ginkgo is a pre-req on building Kubernetes. I identified this and added the support. Ginkgo builds correctly with this change. |
This was referenced Dec 6, 2019
|
Hey @williammartin, we are bumping Kubernetes requirements and would like to stick to released versions. Can you cut a new one (or plan to cut one soon) including this PR? Thanks! |
|
I think we could probably do this today. |
|
Hi @carlosedp; @ansd and I have just cut Ginkgo v1.11.0 |
|
Thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add riscv64 architecture support.