Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve #1020 squeeze and unsqueeze opset v13 #1022

Merged

Conversation

krishnanNuance
Copy link
Contributor

@krishnanNuance krishnanNuance commented Apr 5, 2022

Work contains implementation for squeeze and unsqueeze for opset version 13

@krishnanNuance krishnanNuance force-pushed the 1020-squeeze_and_unsqueeze_opset_v13 branch from a915432 to 2386361 Compare April 5, 2022 10:08
@krishnanNuance krishnanNuance marked this pull request as ready for review April 5, 2022 12:40
@krishnanNuance krishnanNuance changed the title 1020 squeeze and unsqueeze opset v13 #1020 squeeze and unsqueeze opset v13 Apr 6, 2022
@krishnanNuance krishnanNuance changed the title #1020 squeeze and unsqueeze opset v13 resolve #1020 squeeze and unsqueeze opset v13 Apr 6, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 11, 2022

CLA assistant check
All committers have signed the CLA.

@chinhuang007
Copy link
Collaborator

@krishnanNuance Thanks for providing the fix! Please sign the CLA.

@krishnanNuance
Copy link
Contributor Author

I not able to find the test case starting with 'test_sequence_map_' in test_onnx_backend.py. In local setup, currently all cpu tests are passing. Not able to reproduce the failure testcase.

@krishnanNuance
Copy link
Contributor Author

I not able to find the test case starting with 'test_sequence_map_' in test_onnx_backend.py. In local setup, currently all cpu tests are passing. Not able to reproduce the failure testcase.

@chinhuang007 Can you please guide me to reproduce this test scenario? Not able to do so using the commands -Install dependencies and ONNX development stage.

@chudegao
Copy link
Member

@krishnanNuance The test case is from onnx master branch. To reproduce it you need install onnx from source code following https://github.com/onnx/onnx-tensorflow/blob/main/test/backend/test_onnx_backend.py You can update https://github.com/onnx/onnx-tensorflow/blob/main/test/backend/test_onnx_backend.py to exclude new added test case.

@krishnanNuance
Copy link
Contributor Author

@krishnanNuance The test case is from onnx master branch. To reproduce it you need install onnx from source code following https://github.com/onnx/onnx-tensorflow/blob/main/test/backend/test_onnx_backend.py You can update https://github.com/onnx/onnx-tensorflow/blob/main/test/backend/test_onnx_backend.py to exclude new added test case.

Thank you @chudegao . I have excluded the testcase and opened the ticket - #1027 to track the issue.

@krishnanNuance krishnanNuance force-pushed the 1020-squeeze_and_unsqueeze_opset_v13 branch from a28a466 to 71273eb Compare April 18, 2022 04:53
onnx_tf/opset_version.py Outdated Show resolved Hide resolved
@krishnanNuance krishnanNuance force-pushed the 1020-squeeze_and_unsqueeze_opset_v13 branch from 43c533b to 5fd6a2b Compare April 18, 2022 06:17
Copy link
Collaborator

@chinhuang007 chinhuang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants