[DialectBuilder] add helper function for building ONNXSumOp and ONNXConvOp nodes #2572
Conversation
|
Can one of the admins verify this patch? |
|
I'm not sure where unit tests for this kind of change go. Please let me know if you are aware of any related tests that I can mimic. Thanks much! |
|
Can one of the admins verify this patch? |
ashay
changed the title
The DialectBuilder class seems to be missing the function create the ONNXSumOp and ONNXConOp nodes and check their shape. This patch adds the necessary functions. Signed-off-by: Ashay Rane <[email protected]>
|
Can one of the admins verify this patch? |
|
@jenkins-droid test this please |
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Ashay Rane <[email protected]>
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@jenkins-droid test this please |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@tungld / @AlexandreEichenberger Can I get the permissions required to tell Jenkins to start the build and merge PRs that approved and validated using CI please? |
|
@jenkins-droid please test this |
|
@jenkins-droid test this please |
|
Can one of the admins verify this patch? |
|
Now that the checks pass and the branch doesn't need to be updated (from main), can someone merge this PR please? Thanks! |
|
Will do |
|
Jenkins Linux ppc64le Build #12387 [push] [DialectBuilder] add bui... started at 12:10 |
|
Jenkins Linux amd64 Build #13368 [push] [DialectBuilder] add bui... started at 11:02 |
|
Jenkins Linux s390x Build #13394 [push] [DialectBuilder] add bui... started at 12:02 |
|
Jenkins Linux amd64 Build #13368 [push] [DialectBuilder] add bui... failed after 1 hr 23 min |
|
Jenkins Linux s390x Build #13394 [push] [DialectBuilder] add bui... passed after 1 hr 27 min |
|
Jenkins Linux ppc64le Build #12387 [push] [DialectBuilder] add bui... passed after 1 hr 57 min |
* detect LayerNorm in presence of reciprocal and div of 1 (onnx#2609) Signed-off-by: Alexandre Eichenberger <[email protected]> * [NNPA] Use F16 as element type for zTensor (onnx#2611) * Use f16 as element type for zTensor Signed-off-by: Tung D. Le <[email protected]> --------- Signed-off-by: Tung D. Le <[email protected]> * Layernorm: convert instance norm and group norm to layer norm. (onnx#2595) Signed-off-by: Alexandre Eichenberger <[email protected]> Co-authored-by: Tung D. Le <[email protected]> * Parse and set --mcpu in onnx-mlir-opt command (onnx#2614) Signed-off-by: Tung D. Le <[email protected]> * Import dim_param for model inputs and outputs (onnx#2616) * Import dim_param for model inputs and outputs * use argument attributes Signed-off-by: Tung D. Le <[email protected]> --------- Signed-off-by: Tung D. Le <[email protected]> Co-authored-by: Alexandre Eichenberger <[email protected]> * [DialectBuilder] add builder funcrions for ONNXSumOp and ONNXConvOp (onnx#2572) The DialectBuilder class seems to be missing the function create the ONNXSumOp and ONNXConOp nodes and check their shape. This patch adds the necessary functions. Signed-off-by: Ashay Rane <[email protected]> Signed-off-by: Alexandre Eichenberger <[email protected]> Co-authored-by: Alexandre Eichenberger <[email protected]> * [StableHLO] Lowers PadOp (constant mode) & GatherElements Op to StableHLO (onnx#2602) * [Stablehlo] Pad constant mode & GatherElements to Stablehlo Signed-off-by: chongsong.chen <[email protected]> Signed-off-by: Yan Xu <[email protected]> Co-authored-by: chongsong.chen <[email protected]> Co-authored-by: Alexandre Eichenberger <[email protected]> * [build] Add cmake option to enable/disable Java components build (onnx#2613) * Add ONNX_MLIR_ENABLE_JAVA cmake option (default TRUE) Signed-off-by: Boyana Norris <[email protected]> Co-authored-by: Alexandre Eichenberger <[email protected]> Co-authored-by: Alexandre Eichenberger <[email protected]> Co-authored-by: Tung D. Le <[email protected]> Co-authored-by: Ashay Rane <[email protected]> Co-authored-by: Yan Xu <[email protected]> Co-authored-by: chongsong.chen <[email protected]> Co-authored-by: Boyana Norris <[email protected]>
* 'main' of github.ibm.com:zosdev/onnx-mlir: Use dim_params in dynamic dimension analysis (onnx#2620) Update rapidcheck to include the fix for missing <cstdint> include (onnx#2623) Initial changes for llvm uplift (onnx#2568) [build] Add cmake option to enable/disable Java components build (onnx#2613) [StableHLO] Lowers PadOp (constant mode) & GatherElements Op to StableHLO (onnx#2602) [DialectBuilder] add builder funcrions for ONNXSumOp and ONNXConvOp (onnx#2572) Import dim_param for model inputs and outputs (onnx#2616) Parse and set --mcpu in onnx-mlir-opt command (onnx#2614) Layernorm: convert instance norm and group norm to layer norm. (onnx#2595) [NNPA] Use F16 as element type for zTensor (onnx#2611) detect LayerNorm in presence of reciprocal and div of 1 (onnx#2609) # Conflicts: # test/mlir/conversion/onnx_to_krnl/NN/Normalization_O3_SIMD_canonicalize.mlir
The DialectBuilder class seems to be missing the function create the
ONNXSumOp and ONNXConOp nodes and check their shape. This patch adds
the necessary functions.