Allow tighter Config controls over color variation, and ensure all shapes and colors are included. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2017 10:48
I found it frustrating that Cheers would allow me to specify colors, but would then vary the color wildly (0.8 as the default, non-configurable value). This change leaves 0.8 as the default (so that others using this dependency won’t see any change) but expands Config to include “colorRange”, which is applied to the CAEmitterCells.
Previously, if I only used one color, then I’d only get one shape of confetti. Now, there’s a new Array extension, `Array.createAllCombinations(from:and:)` — you can see it in action in `CheerTests.swift`. This function ensures that all the images and colors in the Config will be represented in the confetti.
bryanjclark
changed the title
|
@bryanjclark good PR, and with good test. I like this 👍 . Many thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it frustrating that Cheers would allow me to specify colors,
but would then vary the color wildly (0.8 as the default,
non-configurable value).
This change leaves 0.8 as the default (so that others using this
dependency won’t see any change) but expands Config to include
“colorRange”, which is applied to the CAEmitterCells.