Add a stricter test for feature elimination #1674
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test checks the case where only one feature is left, something that can happen when using feature selection preprocessing.
Instead of trying to sample more features that there are, return the input list. This prevents a crash when the number of features diminishes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new test is similar to the existing
check_disappearing_features, but tests the case where only one feature is left.Such a situation can happen when one uses aggressive feature reduction preprocessing.
It tests for the case encountered in #1560, and discovered a similar problem in SRPClassifier (fixed in the PR).