Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulp eslint #1538

Merged
merged 3 commits into from
Oct 22, 2021
Merged

Gulp eslint #1538

merged 3 commits into from
Oct 22, 2021

Conversation

benjaminpjones
Copy link
Contributor

Addresses Gulp task in #1536

Proposed Changes

Add eslint to gulp using the gulp-eslint7 package.

Notes

  • I did not re-implement debouncing as it seems that gulp does some debounce handling on its own (using the delay option, whose default is 200 ms). I verified this by updating 100 files at once (eslint --fix and git checkout src), and gulp seems to do okay. Let me know if there is a scenario I am missing.
  • gulp-eslint (without the 7) is in a weird place right now. It is not actively maintained, but there are some forks that are gaining traction. gulp-eslint7 seems to be the best fit for this project, since it uses ESLint v7.32. gulp-eslint-new also exists and may be the project to use going forward, but it uses ESLint v8.0, which breaks some rules.

@anoek
Copy link
Member

anoek commented Oct 22, 2021

Awesome, thanks for researching that and making it happen!

@anoek anoek merged commit 532ca20 into online-go:devel Oct 22, 2021
@benjaminpjones benjaminpjones deleted the gulp-eslint branch October 22, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants