Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Gulp task in #1536
Proposed Changes
Add eslint to gulp using the
gulp-eslint7
package.Notes
delay
option, whose default is 200 ms). I verified this by updating 100 files at once (eslint --fix
andgit checkout src
), and gulp seems to do okay. Let me know if there is a scenario I am missing.gulp-eslint
(without the 7) is in a weird place right now. It is not actively maintained, but there are some forks that are gaining traction.gulp-eslint7
seems to be the best fit for this project, since it uses ESLint v7.32.gulp-eslint-new
also exists and may be the project to use going forward, but it uses ESLint v8.0, which breaks some rules.