Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#510 - Part 1 - Move dyllibs to Frameworks folder #529

Merged
merged 4 commits into from
Aug 1, 2019

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Aug 1, 2019

The MacOS code-signing infrastructure expects a certain anatomy to the MacOS folder. We're making a few egregious errors - (which causes issues with signing, and then notarization. This is the first and simplest - we were putting our dyllibs in a libs folder instead of the Frameworks folder. This just moves the dyllibs to the proper folder. The macdyllibbundler tool takes care of mapping the rpaths for Oni2_editor to the new location.

TODO:

  • Update codesign script

@bryphe bryphe changed the title #510 - Part 1 - Move dyllibs to Frameworks folder [WIP] #510 - Part 1 - Move dyllibs to Frameworks folder Aug 1, 2019
@bryphe bryphe changed the title [WIP] #510 - Part 1 - Move dyllibs to Frameworks folder #510 - Part 1 - Move dyllibs to Frameworks folder Aug 1, 2019
@bryphe bryphe merged commit 64c9982 into master Aug 1, 2019
@bryphe bryphe deleted the bugfix/510.1/move-dylibs-frameworks branch August 1, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant