-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#Fix 514 - Remove usage of harfbuzz 1.7.7+ API #527
Conversation
Is there a way to clear the build cache? Have pulled tip of master to try this out (should build on 18.04 now, right?) but still getting the same error, it's coming up so fast it's likely from cached artifacts. |
Hmm, if you're building from source - there may be a different error. The build cache should get invalidated when it sees the new dependency for Would you mind sharing out the error message you are seeing? |
Trashed my entire
|
Ah, that's promising! You'll need to run |
Huzzah! Built.
... as soon as I open a file with syntax highlighting it dies though.
That seems a bit odd too. |
Ah, you'll also need to build the textmate service: https://onivim.github.io/docs/for-developers/building#build-the-textmate-service (That same doc also has instructions for running tests / benchmarks) |
Amazing what you can do when you actually read the docs... can confirm that all builds and runs nicely on Ubuntu 18.04 for me now. |
@awilkins - awesome! Glad its working for you 👍 |
This picks up a change in
reason-fontkit
(revery-ui/reason-fontkit#27) to remove the use ofhb_blob_create_from_file
for better compatibility with system-installed harfbuzz.In #514 , it seems that issues are at least partially stemming from our use of that API, which isn't available in the 1.7.2-ish version we saw.
It sounds like based on @CrossR 's trial that this fixed the issue (although, there was potential still an error with copying configuration)
Based on conversation in Discord - sounds like this fixes it!