Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#Fix 514 - Remove usage of harfbuzz 1.7.7+ API #527

Merged
merged 2 commits into from
Aug 1, 2019

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Aug 1, 2019

This picks up a change in reason-fontkit (revery-ui/reason-fontkit#27) to remove the use of hb_blob_create_from_file for better compatibility with system-installed harfbuzz.

In #514 , it seems that issues are at least partially stemming from our use of that API, which isn't available in the 1.7.2-ish version we saw.

It sounds like based on @CrossR 's trial that this fixed the issue (although, there was potential still an error with copying configuration)

Based on conversation in Discord - sounds like this fixes it!

@bryphe bryphe changed the title [WIP #510 - Remove usage of harfbuzz 1.7.7+ API [WIP] #510 - Remove usage of harfbuzz 1.7.7+ API Aug 1, 2019
@bryphe bryphe changed the title [WIP] #510 - Remove usage of harfbuzz 1.7.7+ API #510 - Remove usage of harfbuzz 1.7.7+ API Aug 1, 2019
@bryphe bryphe changed the title #510 - Remove usage of harfbuzz 1.7.7+ API #Fix 514 - Remove usage of harfbuzz 1.7.7+ API Aug 1, 2019
@bryphe bryphe merged commit f98f448 into master Aug 1, 2019
@bryphe bryphe deleted the packaging/linux/use-earlier-harfbuzz-api branch August 1, 2019 03:50
@awilkins
Copy link

awilkins commented Aug 1, 2019

Is there a way to clear the build cache? Have pulled tip of master to try this out (should build on 18.04 now, right?) but still getting the same error, it's coming up so fast it's likely from cached artifacts.

@bryphe
Copy link
Member Author

bryphe commented Aug 1, 2019

Hmm, if you're building from source - there may be a different error. The build cache should get invalidated when it sees the new dependency for reason-fontkit (you can force it by deleting the _esy folder at the root of the project, though)!

Would you mind sharing out the error message you are seeing?

@awilkins
Copy link

awilkins commented Aug 1, 2019

Trashed my entire ~/.esy folder - must have had the desired effect because things taking much longer... to get to the next error :-) (was def. the harfbuzz error before, have seen it enough..)

info esy build 0.5.8 (using package.json)
File "assets/configuration/dune", line 4, characters 8-18:
4 |  (files setup.json configuration.json keybindings.json))
            ^^^^^^^^^^
Error: No rule found for assets/configuration/setup.json
error: command failed: 'refmterr' 'dune' 'build' '-p' 'Oni2' '-j4' (exited with 1)
esy-build-package: exiting with errors above...
error: build failed with exit code: 1
  
esy: exiting due to errors above

@bryphe
Copy link
Member Author

bryphe commented Aug 1, 2019

Ah, that's promising! You'll need to run esy bootstrap now to fix that error 👍

@awilkins
Copy link

awilkins commented Aug 1, 2019

Huzzah! Built.

esy run

... as soon as I open a file with syntax highlighting it dies though.

$ esy test
error: project is not installed, run `esy install`
  
esy: exiting due to errors above
awilkins@ryoko:~/oni/oni2 (master=)
$ esy install 
info install 0.5.8 (using package.json)
awilkins@ryoko:~/oni/oni2 (master=)
$ esy test
error: project is not installed, run `esy install`
  
esy: exiting due to errors above

That seems a bit odd too.

@bryphe
Copy link
Member Author

bryphe commented Aug 1, 2019

Ah, you'll also need to build the textmate service: https://onivim.github.io/docs/for-developers/building#build-the-textmate-service

(That same doc also has instructions for running tests / benchmarks)

@awilkins
Copy link

awilkins commented Aug 1, 2019

Amazing what you can do when you actually read the docs... can confirm that all builds and runs nicely on Ubuntu 18.04 for me now.

@bryphe
Copy link
Member Author

bryphe commented Aug 1, 2019

@awilkins - awesome! Glad its working for you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants