[Malleability] Event

[UlyanaAndrukhiv]

Close: #6651

Context

This pull request addresses an issue related to the malleability of the ID() method in Event.

• The ID() method has been fixed by using MakeID. These changes have no impact on tests.
• Removed eventWrapper because it is essentially equivalent to Event.
• Removed eventIDWrapper because it is unused after these changes.
• Removed the unused Encode method.
• Removed the unused getEvents test helper function.
• Added an extra unit test to ensure that Event is not malleable (replacing the existing test, which only partially verified non-malleability).

[durkmurder]

Looks good but I think we can simplify the implementation more by removing the Fingerprint.

[durkmurder]

I believe it's redundant, we don't need to implement the Fingerprint for this type, it essentially has the same fields as the original type. I would propose to get rid of it and in place where we need to fingerprint we use: fingerprint.Fingerprint(event)

[UlyanaAndrukhiv]

@durkmurder, thank you for this note.The Fingerprint method defines a specific field order that differs from the Event struct, so we can't easily remove it.

[UlyanaAndrukhiv]

There was a discussion about this, and the conclusion is that we can change the field order for generating the RLP-encoded representation of the Event type. This simplifies the code and improves readability. However, this change will affect the Rosetta side. Since all these changes will be introduced in a new spork, we can do this, but we must also update the field order on the Rosetta side. Changing this order in Rosetta is crucial.

Based on @durkmurder ’s comment, I removed the Fingerprint implementation for the Event type and updated the tests accordingly (see commit).

@franklywatson , I want to bring this to your attention — we will need to create an issue in flow/rosetta to track this update. I’ve also described the previous and current field order for Event in the issue for this task (#6651).

[durkmurder]

@jordanschalm can we get your review?

[durkmurder]

⭐