[Malleability] QuorumCertificate, TimeoutCertificate, LightCollection, ExecutionResult and Attestation malleability tests.

engine/execution/ingestion/block_queue/queue_test.go

@@ -2,6 +2,7 @@ package block_queue
 
 import (
 	"errors"
+	"math/rand"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -11,6 +12,16 @@ import (
 	"github.com/onflow/flow-go/utils/unittest"
 )
 
+// TestMissingCollectionID_Malleability confirms that the MissingCollection struct, which implements
+// the [flow.IDEntity] interface, is resistant to tampering.
+func TestMissingCollectionID_Malleability(t *testing.T) {
+	unittest.RequireEntityNonMalleable(t, &MissingCollection{
+		BlockID:   unittest.IdentifierFixture(),
+		Height:    rand.Uint64(),
+		Guarantee: unittest.CollectionGuaranteeFixture(),
+	})
+}
+
 func TestSingleBlockBecomeReady(t *testing.T) {
 	t.Parallel()
 	// Given a chain

model/flow/collection_test.go

@@ -21,3 +21,11 @@ func TestLightCollectionFingerprint(t *testing.T) {
 	assert.Equal(t, colID, decodedID)
 	assert.Equal(t, col.Light(), decoded)
 }
+
+// TestLightCollectionID_Malleability confirms that the LightCollection struct, which implements
+// the [flow.IDEntity] interface, is resistant to tampering.
+func TestLightCollectionID_Malleability(t *testing.T) {
+	unittest.RequireEntityNonMalleable(t, &flow.LightCollection{
+		Transactions: unittest.IdentifierListFixture(5),
+	})
+}

model/flow/execution_result_test.go

@@ -11,6 +11,12 @@ import (
 	"github.com/onflow/flow-go/utils/unittest"
 )
 
+// TestExecutionResultID_Malleability confirms that the ExecutionResult struct, which implements
+// the [flow.IDEntity] interface, is resistant to tampering.
+func TestExecutionResultID_Malleability(t *testing.T) {
+	unittest.RequireEntityNonMalleable(t, unittest.ExecutionResultFixture(unittest.WithServiceEvents(3)))
+}
+
 // TestExecutionResultGroupBy tests the GroupBy method of ExecutionResultList:
 // * grouping should preserve order and multiplicity of elements
 // * group for unknown identifier should be empty

model/flow/quorum_certificate_test.go

@@ -0,0 +1,13 @@
+package flow_test
+
+import (
+	"testing"
+
+	"github.com/onflow/flow-go/utils/unittest"
+)
+
+// TestQuorumCertificateID_Malleability confirms that the QuorumCertificate struct, which implements
+// the [flow.IDEntity] interface, is resistant to tampering.
+func TestQuorumCertificateID_Malleability(t *testing.T) {
+	unittest.RequireEntityNonMalleable(t, unittest.QuorumCertificateFixture())
+}

model/flow/resultApproval_test.go

@@ -14,3 +14,9 @@ func TestResultApprovalEncode(t *testing.T) {
 	id := ra.ID()
 	assert.NotEqual(t, flow.ZeroID, id)
 }
+
+// TestAttestationID_Malleability confirms that the Attestation struct, which implements
+// the [flow.IDEntity] interface, is resistant to tampering.
+func TestAttestationID_Malleability(t *testing.T) {
+	unittest.RequireEntityNonMalleable(t, unittest.AttestationFixture())
+}

model/flow/timeout_certificate_test.go

@@ -0,0 +1,14 @@
+package flow_test
+
+import (
+	"testing"
+
+	"github.com/onflow/flow-go/consensus/hotstuff/helper"
+	"github.com/onflow/flow-go/utils/unittest"
+)
+
+// TestTimeoutCertificateID_Malleability confirms that the TimeoutCertificate struct, which implements
+// the [flow.IDEntity] interface, is resistant to tampering.
+func TestTimeoutCertificateID_Malleability(t *testing.T) {
+	unittest.RequireEntityNonMalleable(t, helper.MakeTC())
+}

utils/unittest/entity.go

@@ -285,6 +285,12 @@ func generateCustomFlowValue(field reflect.Value) any {
 		return flow.ClusterQCVoteDataFromQC(QuorumCertificateWithSignerIDsFixture())
 	case reflect.TypeOf(flow.QuorumCertificate{}):
 		return *QuorumCertificateFixture()
+	case reflect.TypeOf(flow.CollectionGuarantee{}):
+		return *CollectionGuaranteeFixture()
+	case reflect.TypeOf(flow.Chunk{}):
+		return *ChunkFixture(IdentifierFixture(), uint(rand.Uint32()), StateCommitmentFixture())
+	case reflect.TypeOf(flow.ServiceEvent{}):
+		return EpochCommitFixture().ServiceEvent()
 	case reflect.TypeOf(flow.TimeoutCertificate{}):
 		return flow.TimeoutCertificate{
 			View:          rand.Uint64(),