Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Implement subscribe transaction statuses by transaction ID #6737

Open
wants to merge 58 commits into
base: master
Choose a base branch
from

Conversation

Guitarheroua
Copy link
Contributor

@Guitarheroua Guitarheroua commented Nov 19, 2024

Closes #6573 and #6574

This PR implements a new subscription to a transaction by txID and changes the existing send and subscribe endpoint.

This PR introduces a separate transactionSubscriptionMetadata private module and moves the handling of transactions status logic there to simplify streaming module logic.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 70.61404% with 67 lines in your changes missing coverage. Please review.

Project coverage is 41.25%. Comparing base (d5a249f) to head (6004c7a).

Files with missing lines Patch % Lines
...s/rpc/backend/transaction_subscription_metadata.go 62.50% 32 Missing and 10 partials ⚠️
.../access/rpc/backend/backend_stream_transactions.go 75.43% 10 Missing and 4 partials ⚠️
access/api.go 0.00% 4 Missing ⚠️
access/mock/api.go 0.00% 2 Missing ⚠️
cmd/util/cmd/run-script/cmd.go 0.00% 2 Missing ⚠️
...ts/data_providers/transaction_statuses_provider.go 92.30% 1 Missing ⚠️
engine/access/rpc/backend/backend_transactions.go 83.33% 1 Missing ⚠️
...ss/rpc/backend/transactions_local_data_provider.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6737      +/-   ##
==========================================
+ Coverage   41.24%   41.25%   +0.01%     
==========================================
  Files        2152     2153       +1     
  Lines      189202   189163      -39     
==========================================
+ Hits        78036    78043       +7     
+ Misses     104660   104608      -52     
- Partials     6506     6512       +6     
Flag Coverage Δ
unittests 41.25% <70.61%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Guitarheroua Guitarheroua self-assigned this Nov 20, 2024
@Guitarheroua Guitarheroua marked this pull request as ready for review November 21, 2024 07:42
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few small comments, but otherwise looks good

Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a couple more comments, but otherwise looks good.

peterargue
peterargue previously approved these changes Dec 27, 2024
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good other than missing irrecoverable error

@peterargue peterargue requested a review from durkmurder January 2, 2025 17:55
@Guitarheroua Guitarheroua requested a review from a team as a code owner January 16, 2025 08:02
@peterargue peterargue dismissed their stale review February 10, 2025 22:27

there was a significant refactor since my review

Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments about finishing touches, but otherwise I think this looks good

@peterargue
Copy link
Contributor

@durkmurder can you take another look 🙏

Copy link
Member

@durkmurder durkmurder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments, still have tests to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Pending response from send and subscribe should return immediately
4 participants