-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Implement subscribe transaction statuses by transaction ID #6737
base: master
Are you sure you want to change the base?
[Access] Implement subscribe transaction statuses by transaction ID #6737
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6737 +/- ##
==========================================
+ Coverage 41.24% 41.25% +0.01%
==========================================
Files 2152 2153 +1
Lines 189202 189163 -39
==========================================
+ Hits 78036 78043 +7
+ Misses 104660 104608 -52
- Partials 6506 6512 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few small comments, but otherwise looks good
Co-authored-by: Peter Argue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a couple more comments, but otherwise looks good.
Co-authored-by: Peter Argue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good other than missing irrecoverable error
…isarchuk/6573-pending-should-return-immediately
there was a significant refactor since my review
…' of github.com:The-K-R-O-K/flow-go into AndriiSlisarchuk/6573-pending-should-return-immediately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments about finishing touches, but otherwise I think this looks good
@durkmurder can you take another look 🙏 |
Co-authored-by: Peter Argue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch of comments, still have tests to review.
engine/access/rest/websockets/data_providers/transaction_statuses_provider.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Yurii Oleksyshyn <[email protected]>
…isarchuk/6573-pending-should-return-immediately
Closes #6573 and #6574
This PR implements a new subscription to a transaction by txID and changes the existing send and subscribe endpoint.
This PR introduces a separate
transactionSubscriptionMetadata
private module and moves the handling of transactions status logic there to simplify streaming module logic.