Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report the stored path of the untyped-capability #6328

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Aug 13, 2024

Depends on onflow/cadence#3524

@SupunS SupunS self-assigned this Aug 13, 2024
@SupunS SupunS requested review from a team August 13, 2024 01:51
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.52%. Comparing base (3a2217d) to head (30bc437).

Files Patch % Lines
...util/ledger/migrations/cadence_values_migration.go 89.47% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6328   +/-   ##
=======================================
  Coverage   41.52%   41.52%           
=======================================
  Files        2009     2009           
  Lines      143256   143260    +4     
=======================================
+ Hits        59483    59485    +2     
  Misses      77588    77588           
- Partials     6185     6187    +2     
Flag Coverage Δ
unittests 41.52% <89.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SupunS SupunS force-pushed the supun/improve-reporting branch 2 times, most recently from 1d67b2f to 722cb0b Compare August 13, 2024 03:36
@SupunS SupunS force-pushed the supun/improve-reporting branch from 722cb0b to a0da8eb Compare August 13, 2024 03:37
@SupunS SupunS marked this pull request as ready for review August 13, 2024 04:13
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SupunS SupunS enabled auto-merge August 13, 2024 04:29
@SupunS SupunS added this pull request to the merge queue Aug 13, 2024
Merged via the queue into master with commit 67d5beb Aug 13, 2024
55 checks passed
@SupunS SupunS deleted the supun/improve-reporting branch August 13, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants