-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not return an error when block is unavailable due to expiry #5853
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5853 +/- ##
==========================================
+ Coverage 55.41% 55.52% +0.10%
==========================================
Files 1108 1132 +24
Lines 86565 89476 +2911
==========================================
+ Hits 47970 49679 +1709
- Misses 33958 35021 +1063
- Partials 4637 4776 +139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
7e3bdd6
to
370614e
Compare
370614e
to
3ba3a7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test @zhangchiqing!
Closes #5852
#5607 broke the
getBlock
function in Cadence.When a block is not available, indicate it via the
exists
return value, but do not return an error.blockInfo
had no tests, which is why #5607 silently broke thegetBlock
function.This PR fixes the bug and adds a test for
blockInfo
.