Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ./integration dependencies #5314

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Jan 29, 2024

Clean up the replace statements in ./integration.

./integration still uses the untagged version of flow-emulator from branch https://github.com/onflow/flow-emulator/tree/tarak/v0.58.1-0-with-crypto-type-fixes on this commit.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c665488) 55.70% compared to head (89627c8) 55.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5314      +/-   ##
==========================================
- Coverage   55.70%   55.69%   -0.02%     
==========================================
  Files        1002     1002              
  Lines       96879    96879              
==========================================
- Hits        53971    53959      -12     
- Misses      38849    38853       +4     
- Partials     4059     4067       +8     
Flag Coverage Δ
unittests 55.69% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarakby tarakby marked this pull request as ready for review January 29, 2024 20:32
@tarakby tarakby changed the title Clean up./integration dependencies Clean up ./integration dependencies Jan 29, 2024
@tarakby tarakby requested a review from jordanschalm January 30, 2024 14:12
@tarakby tarakby added this pull request to the merge queue Jan 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2024
@tarakby tarakby added this pull request to the merge queue Jan 30, 2024
Merged via the queue into master with commit 08ca433 Jan 30, 2024
51 checks passed
@tarakby tarakby deleted the tarak/cleanup-integration branch January 30, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants