Set the correct testnet/mainnet evm state storage account #5294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5294 +/- ##
==========================================
- Coverage 55.61% 55.57% -0.04%
==========================================
Files 1002 988 -14
Lines 96600 95786 -814
==========================================
- Hits 53720 53232 -488
+ Misses 38820 38520 -300
+ Partials 4060 4034 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
turbolent
approved these changes
Jan 25, 2024
sideninja
approved these changes
Jan 25, 2024
ramtinms
approved these changes
Jan 26, 2024
|
Do we need to update the storage exception code or it already read the value from this function? |
|
@ramtinms Its already set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short doc about the accounts here:
https://www.notion.so/dapperlabs/EVM-Contract-and-storage-address-c45c953569854b1db4b0feec8258783d