Update stable cadence feature branch #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces hash-based validation of Cadence values in order to prepare for atree inlining to be incorporated into the migration program. Also added validate flag to enable validation during migration since enabling validation can increase duration of migration.
Added flag --log-verbose-validation-error to enable logging of entire Cadence values on validation error during atree migration.
This is a temporary (and inefficient) workaround to check number of fields in Cadence CompositeValue. In the future, CompositeValue.FieldCount() will be added to Cadence, so that function can be used to improve this workaround.
…e-value-validation Replace hash-based validation of migrated Cadence values to use `Equal()`
# Conflicts: # fvm/evm/types/events.go
turbolent
requested review from
yhassanzadeh13,
zhangchiqing,
ramtinms,
janezpodhostnik,
AlexHentschel,
peterargue,
durkmurder and
jordanschalm
as code owners
This was referenced Jan 25, 2024
Closed
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5290 +/- ##
==========================================================
- Coverage 55.62% 49.85% -5.78%
==========================================================
Files 995 190 -805
Lines 95196 17043 -78153
==========================================================
- Hits 52954 8497 -44457
+ Misses 38264 7955 -30309
+ Partials 3978 591 -3387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Lots of unit tests are still failing, because the new required Burner contract isn't getting deployed during bootstrapping. @joshuahannan once we know if it's integrated or not, I can add it (or not) |
dsainati1
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5285 + #5289 by @SupunS and @joshuahannan + some more updates and fixes.
Uses onflow/flow-emulator#552 for integration tests